You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/30 03:23:13 UTC

[GitHub] [dolphinscheduler] dailidong commented on pull request #7041: [2.0.1-cherrypick] SPI(Task ,Alert ,DataSource)

dailidong commented on pull request #7041:
URL: https://github.com/apache/dolphinscheduler/pull/7041#issuecomment-982247765


   A hard work!
   
   I think it would be a better choice to submit the basic implementation of SPI, alert SPI, task SPI, and datasource SPI separately.
   
   I have a suggestion that a PR solves a problem. For example, the PR of Alert SPI only solves Alert and task SPI only solves Task Plugin. It is not a good practice to mix them together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org