[GitHub] [kafka] mimaison commented on a diff in pull request #11473: KAFKA-13436: Omitted BrokerTopicMetrics metrics in the documentation

[GitBox <gi...@apache.org>]

mimaison commented on code in PR #11473:
URL: https://github.com/apache/kafka/pull/11473#discussion_r850244956


##########
docs/ops.html:
##########
@@ -1447,12 +1447,32 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
         <td>kafka.network:type=RequestMetrics,name=RequestsPerSec,request={Produce|FetchConsumer|FetchFollower},version=([0-9]+)</td>
         <td></td>
       </tr>
+      <tr>
+        <td>Produce request rate</td>
+        <td>kafka.server:type=BrokerTopicMetrics,name=TotalProduceRequestsPerSec</td>
+        <td></td>
+      </tr>
+      <tr>
+        <td>Fetch request rate</td>
+        <td>kafka.server:type=BrokerTopicMetrics,name=TotalFetchRequestsPerSec</td>
+        <td></td>
+      </tr>
       <tr>
         <td>Error rate</td>
         <td>kafka.network:type=RequestMetrics,name=ErrorsPerSec,request=([-.\w]+),error=([-.\w]+)</td>
         <td>Number of errors in responses counted per-request-type, per-error-code. If a response contains
             multiple errors, all are counted. error=NONE indicates successful responses.</td>
       </tr>
+      <tr>
+        <td>Failed produce request rate</td>
+        <td>kafka.server:type=BrokerTopicMetrics,name=FailedProduceRequestsPerSec</td>
+        <td></td>

Review Comment:
   Yes let's try to include descriptions as above we recommend to graph and alert on these metrics



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org