You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/25 13:39:16 UTC
[GitHub] [flink] rkhachatryan opened a new pull request, #19819: F27169
rkhachatryan opened a new pull request, #19819:
URL: https://github.com/apache/flink/pull/19819
## What is the purpose of the change
Fix test instability caused by changelog write timeouts.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19819:
URL: https://github.com/apache/flink/pull/19819#issuecomment-1137257175
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "85506ac60575794e4db49523554655aefaa0c7a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "85506ac60575794e4db49523554655aefaa0c7a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 85506ac60575794e4db49523554655aefaa0c7a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on PR #19819:
URL: https://github.com/apache/flink/pull/19819#issuecomment-1138507949
Thanks a lot for the review!
CI is green, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a diff in pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on code in PR #19819:
URL: https://github.com/apache/flink/pull/19819#discussion_r881765652
##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/TestJobExecutor.java:
##########
@@ -77,28 +77,28 @@ private TestJobExecutor(
public static TestJobExecutor execute(
TestJobWithDescription testJob, MiniClusterWithClientResource miniClusterResource)
throws Exception {
- LOG.debug("submitGraph: {}", testJob.jobGraph);
+ LOG.info("submitGraph: {}", testJob.jobGraph);
JobID job = miniClusterResource.getClusterClient().submitJob(testJob.jobGraph).get();
waitForAllTaskRunning(miniClusterResource.getMiniCluster(), job, false);
return new TestJobExecutor(testJob, job, miniClusterResource);
}
public TestJobExecutor waitForAllRunning() throws Exception {
- LOG.debug("waitForAllRunning in {}", jobID);
+ LOG.info("waitForAllRunning in {}", jobID);
Review Comment:
I think it should be actually info because this is some test execution phase.
Besides that, changing in tools/ci/log4j.properties would only help when running on CI, not locally for example.
So I'd rather keep it `info` in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19819:
URL: https://github.com/apache/flink/pull/19819#discussion_r881697420
##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/TestJobExecutor.java:
##########
@@ -77,28 +77,28 @@ private TestJobExecutor(
public static TestJobExecutor execute(
TestJobWithDescription testJob, MiniClusterWithClientResource miniClusterResource)
throws Exception {
- LOG.debug("submitGraph: {}", testJob.jobGraph);
+ LOG.info("submitGraph: {}", testJob.jobGraph);
JobID job = miniClusterResource.getClusterClient().submitJob(testJob.jobGraph).get();
waitForAllTaskRunning(miniClusterResource.getMiniCluster(), job, false);
return new TestJobExecutor(testJob, job, miniClusterResource);
}
public TestJobExecutor waitForAllRunning() throws Exception {
- LOG.debug("waitForAllRunning in {}", jobID);
+ LOG.info("waitForAllRunning in {}", jobID);
Review Comment:
Why not change the log level to DEBUG for this particular class in tools/ci/log4j.properties=
##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/lifecycle/TestJobExecutor.java:
##########
@@ -77,28 +77,28 @@ private TestJobExecutor(
public static TestJobExecutor execute(
TestJobWithDescription testJob, MiniClusterWithClientResource miniClusterResource)
throws Exception {
- LOG.debug("submitGraph: {}", testJob.jobGraph);
+ LOG.info("submitGraph: {}", testJob.jobGraph);
JobID job = miniClusterResource.getClusterClient().submitJob(testJob.jobGraph).get();
waitForAllTaskRunning(miniClusterResource.getMiniCluster(), job, false);
return new TestJobExecutor(testJob, job, miniClusterResource);
}
public TestJobExecutor waitForAllRunning() throws Exception {
- LOG.debug("waitForAllRunning in {}", jobID);
+ LOG.info("waitForAllRunning in {}", jobID);
Review Comment:
Why not change the log level to DEBUG for this particular class in tools/ci/log4j.properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #19819: [FLINK-27169][tests] Set timeout for operator lifecycle tests and increase changelog upload timeout
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged PR #19819:
URL: https://github.com/apache/flink/pull/19819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org