You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flex.apache.org by trimedia <gi...@git.apache.org> on 2014/10/07 19:06:59 UTC

[GitHub] flex-utilities pull request: Patch for bug FLEX-34445

GitHub user trimedia opened a pull request:

    https://github.com/apache/flex-utilities/pull/1

    Patch for bug FLEX-34445

    https://issues.apache.org/jira/browse/FLEX-34445
    Change line 2285 from
    	_os.os + abortInfo);
    to 
    	_os.os + "&info=" + abortInfo);

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trimedia/flex-utilities patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flex-utilities/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
    
----
commit 89d54f1588de8d5dea135eac43adf27d3e6c8b98
Author: trimedia <tr...@hotmail.com>
Date:   2014-10-07T17:06:15Z

    Patch for bug FLEX-34445
    
    https://issues.apache.org/jira/browse/FLEX-34445
    Change line 2285 from
    	_os.os + abortInfo);
    to 
    	_os.os + "&info=" + abortInfo);

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

> I¹m confused.  Why doesn¹t fixer/assignee resolve and reporter close to
> confirm the resolver¹s decision?

You can do (and certainly nothing wrong in working that way) but it's not enforced by the current workflow and it's certainly not common practice as shown by previous JIRA entries. IMO it's better for person who tested the fix to close it and that person may or may not be the person who raised it or who provided the fix or even applied the fix.

Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by Alex Harui <ah...@adobe.com>.

I¹m confused.  Why doesn¹t fixer/assignee resolve and reporter close to
confirm the resolver¹s decision?

On 10/7/14, 6:23 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:

>Hi,
>
>Our workflow on closed and resolved. Note that you can skip the resolved
>step altogether and if resolved the close step is optional.
>https://issues.apache.org/jira/plugins/servlet/project-config/FLEX/workflo
>ws# 
>
>Thanks,
>Justin

Re: Installer Updates

Posted by Alex Harui <ah...@adobe.com>.

Hi Neil,

Thanks for contributing!  I am hopeful that one of our recently-added
committers will be eager enough to try out your patches.  Otherwise, I¹ll
try to remember to look at it in a couple of days.

-Alex

On 10/8/14, 9:43 AM, "Neil Madsen" <li...@cranialinteractive.com> wrote:

>I've gone ahead and done some patches for the installer.
>
>These issues have been addressed:
>
>FLEX-34445 [1] (This one is committed I believe)
>FLEX-34398 [2] (Patch is attached to jira)
>FLEX-34408 [3] 
>
>I ended up with FLEX-34398 and FLEX-34408 being addressed in the same
>patch.
>There is a comment on jira for FLEX-34408 that shows the single line added
>in case someone wants to change/move it without having to search through
>the
>code. 
>
>If someone gets a chance to look them over that would be great.
>
>The remaining issues that Justin had posted earlier are
>
>> Installer issues that also also good to fix before making a release
>>(some
>> would be required IMO):
>> FLEX-34559 FLEX-34540 FLEX-34507 FLEX-34471 FLEX-34452 FLEX-34447
>> FLEX-34446 FLEX-34425 FLEX-34409 FLEX-34400 FLEX-34397
>
>Neil
>
>[1] https://issues.apache.org/jira/browse/FLEX-34445
>[2] https://issues.apache.org/jira/browse/FLEX-34398
>[3] https://issues.apache.org/jira/browse/FLEX-34408
>

Installer Updates

Posted by Neil Madsen <li...@cranialinteractive.com>.

I've gone ahead and done some patches for the installer.

These issues have been addressed:

FLEX-34445 [1] (This one is committed I believe) 
FLEX-34398 [2] (Patch is attached to jira)
FLEX-34408 [3] 

I ended up with FLEX-34398 and FLEX-34408 being addressed in the same patch.
There is a comment on jira for FLEX-34408 that shows the single line added
in case someone wants to change/move it without having to search through the
code. 

If someone gets a chance to look them over that would be great.

The remaining issues that Justin had posted earlier are

> Installer issues that also also good to fix before making a release (some
> would be required IMO):
> FLEX-34559 FLEX-34540 FLEX-34507 FLEX-34471 FLEX-34452 FLEX-34447
> FLEX-34446 FLEX-34425 FLEX-34409 FLEX-34400 FLEX-34397

Neil

[1] https://issues.apache.org/jira/browse/FLEX-34445
[2] https://issues.apache.org/jira/browse/FLEX-34398
[3] https://issues.apache.org/jira/browse/FLEX-34408

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

Our workflow on closed and resolved. Note that you can skip the resolved step altogether and if resolved the close step is optional.
https://issues.apache.org/jira/plugins/servlet/project-config/FLEX/workflows# 

Thanks,
Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by OmPrakash Muppirala <bi...@gmail.com>.

On Oct 7, 2014 6:18 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > Did not want to close it without you getting a chance to verify it.
>
> Issue hadn't been resolved so I assumed you wanted me to resolve it.
>
> > Usually fixer resolves the issue, and the reporter closes the issue
>
> Generally not the case in our bug base, resolved is not used that often,
1596 in resolved state vs 29409 in closed state.
>
> Justin
>
>

You are right.  I think I was distracted :-)

Om

>
>

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

> Did not want to close it without you getting a chance to verify it.

Issue hadn't been resolved so I assumed you wanted me to resolve it.

> Usually fixer resolves the issue, and the reporter closes the issue

Generally not the case in our bug base, resolved is not used that often, 1596 in resolved state vs 29409 in closed state.

Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by OmPrakash Muppirala <bi...@gmail.com>.

On Oct 7, 2014 6:01 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > Justin, see if you can close the JIRA ticket you opened for this.
>
> Done. BTW Not sure why you are asking me to close it as anyone with the
right JIRA permissions (ie you) could close it.

Did not want to close it without you getting a chance to verify it.

Usually fixer resolves the issue, and the reporter closes the issue.

Thanks,
Om

>
> Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

> Justin, see if you can close the JIRA ticket you opened for this.

Done. BTW Not sure why you are asking me to close it as anyone with the right JIRA permissions (ie you) could close it.

Justin

Re: [GitHub] flex-utilities pull request: Patch for bug FLEX-34445

Posted by OmPrakash Muppirala <bi...@gmail.com>.

Justin, see if you can close the JIRA ticket you opened for this.

Thanks,
Om

On Tue, Oct 7, 2014 at 3:11 PM, bigosmallm <gi...@git.apache.org> wrote:

> Github user bigosmallm commented on the pull request:
>
>     https://github.com/apache/flex-utilities/pull/1#issuecomment-58271561
>
>     Thanks, trimedia!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>