You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by aleph-zero <gi...@git.apache.org> on 2015/08/27 00:13:33 UTC
[GitHub] drill pull request: First pass at test re-factoring
GitHub user aleph-zero opened a pull request:
https://github.com/apache/drill/pull/135
First pass at test re-factoring
Unifying test class hierarchy and adding randomization functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleph-zero/drill issues/DRILL-2026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 3a9a0a1469265b7b75c11d4b36895e627a835b55
Author: andrew <an...@dremio.com>
Date: 2015-08-26T22:11:17Z
First pass at test re-factoring
Unifying test class hierarchy and adding randomization functionality.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: First pass at test re-factoring
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/135#issuecomment-203057745
@aleph-zero I see the last update was a few months back. I know @jaltekruse mentioned about this in the hangout a while back. What is the latest on this (I forget)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: First pass at test re-factoring
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/135#discussion_r38984610
--- Diff: exec/java-exec/src/test/java/org/apache/drill/DrillIntegrationTestBase.java ---
@@ -80,221 +93,303 @@
}
};
- public final TestRule resetWatcher = new TestWatcher() {
- @Override
- protected void failed(Throwable e, Description description) {
- try {
- resetClientAndBit();
- } catch (Exception e1) {
- throw new RuntimeException("Failure while resetting client.", e1);
- }
- }
- };
-
- protected static DrillClient client;
- protected static Drillbit[] bits;
- protected static RemoteServiceSet serviceSet;
- protected static DrillConfig config;
- protected static BufferAllocator allocator;
+ /* *** Cluster Scope Settings *** */
+
+ public static final int MIN_NUM_DRILLBITS = 1;
+ public static final int MAX_NUM_DRILLBITS = 5;
+ public static final int DEFAULT_NUM_DRILLBITS = 2;
--- End diff --
any particular reason you changed default num drillbits from 1 to 2 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: First pass at test re-factoring
Posted by adeneche <gi...@git.apache.org>.
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/135#discussion_r38984803
--- Diff: common/pom.xml ---
@@ -98,26 +100,49 @@
<artifactId>antlr-runtime</artifactId>
<version>3.4</version>
</dependency>
-
<dependency>
- <groupId>joda-time</groupId>
- <artifactId>joda-time</artifactId>
- <version>2.3</version>
+ <groupId>joda-time</groupId>
+ <artifactId>joda-time</artifactId>
+ <version>2.3</version>
</dependency>
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>com.carrotsearch.randomizedtesting</groupId>
--- End diff --
what motivated this change ? what are the benefits of randomizedtesting vs surefire plugin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---