You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/08/09 06:27:50 UTC
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] Deactivate angular debugging cl...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1305
[ZEPPELIN-1310] Deactivate angular debugging classes
### What is this PR for?
This PR removes the angular debug classes added to HTML elements (that plugins like batarang are using), it follows advices from the angular [documentation](https://code.angularjs.org/1.5.5/docs/guide/production) and should improve performances.
### What type of PR is it?
Improvement
### Todos
* [ ] - Add documentation on how to easily activate it for people wanted to debug
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1310
### How should this be tested?
Do a `./grunt build` or launch Zeppelin normally
Check in the console there should not be any `ng-scope` or such in the html classes
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1310
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1305
----
commit 0acbcb5dfaaa0d3b703ff4dc61d56651d89f4ccd
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-09T06:22:45Z
Add setting to deactivate angular debugging classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] Deactivate angular debugging cl...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1305
[ZEPPELIN-1310] Deactivate angular debugging classes
### What is this PR for?
This PR removes the angular debug classes added to HTML elements (that plugins like batarang are using), it follows advices from the angular [documentation](https://code.angularjs.org/1.5.5/docs/guide/production) and should improve performances.
### What type of PR is it?
Improvement
### Todos
* [x] - Add documentation on how to easily activate it for people wanted to debug
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1310
### How should this be tested?
Do a `./grunt build` or launch Zeppelin normally
Check in the console there should not be any `ng-scope` or such in the html classes
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1310
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1305
----
commit 0acbcb5dfaaa0d3b703ff4dc61d56651d89f4ccd
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-09T06:22:45Z
Add setting to deactivate angular debugging classes
commit 33ac1247b18d750e4aed34adfaca8f3143f0d726
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-09T06:55:53Z
Update zeppelin-web CONTRIBUTING to document how to activate angular debug classes
commit 360fbd0dea1672c0286c1f8cca25f4ae4b5b23ea
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-10T01:14:34Z
Remove ng-scope from selenium selectors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] Deactivate angular debugging cl...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1305: [ZEPPELIN-1310] Deactivate angular debugging classes
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1305
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1305: [ZEPPELIN-1310] Deactivate angular debugging classes
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1305
This PR is going to have to wait,
When activating this option, things like:
`angular.element().scope().functionIWantToCall()` are not possible anymore.
We are relying on it to call 5 different functions in our code, and bypassing it would mean some refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] Deactivate angular debugging cl...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1305
[ZEPPELIN-1310] Deactivate angular debugging classes
### What is this PR for?
This PR removes the angular debug classes added to HTML elements (that plugins like batarang are using), it follows advices from the angular [documentation](https://code.angularjs.org/1.5.5/docs/guide/production) and should improve performances.
### What type of PR is it?
Improvement
### Todos
* [x] - Add documentation on how to easily activate it for people wanted to debug
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1310
### How should this be tested?
Do a `./grunt build` or launch Zeppelin normally
Check in the console there should not be any `ng-scope` or such in the html classes
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1310
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1305
----
commit 0acbcb5dfaaa0d3b703ff4dc61d56651d89f4ccd
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-09T06:22:45Z
Add setting to deactivate angular debugging classes
commit 33ac1247b18d750e4aed34adfaca8f3143f0d726
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-08-09T06:55:53Z
Update zeppelin-web CONTRIBUTING to document how to activate angular debug classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] Deactivate angular debugging cl...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1305: [ZEPPELIN-1310] [WIP] Deactivate angular debugging cla...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1305
Let's close this PR, this would also break most of the custom angular display notebooks.
Too much changes need to be done before this can be applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1305: [ZEPPELIN-1310] [WIP] Deactivate angular debugg...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---