[GitHub] mistercrunch commented on a change in pull request #4543: Setting up compression using flask-compress

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4543: Setting up compression using flask-compress
URL: https://github.com/apache/incubator-superset/pull/4543#discussion_r172600154
 
 

 ##########
 File path: superset/utils.py
 ##########
 @@ -838,3 +843,38 @@ def get_filter_key(f):
 def get_update_perms_flag():
     val = os.environ.get('SUPERSET_UPDATE_PERMS')
     return val.lower() not in ('0', 'false', 'no') if val else True
+
+
+def gzipped(f):
 
 Review comment:
   Flask-Compress only takes care of static files :( , I agree that this seems in-scope for it, I'll open a PR with them in parallel to this. 
   
   I actually tested by looking at headers and the decorator does do the difference.
   
   Looks like it's not py3 compatible, going to tweak this now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services