You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/28 07:44:48 UTC
[GitHub] [airflow] kaxil opened a new pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
kaxil opened a new pull request #17282:
URL: https://github.com/apache/airflow/pull/17282
This adds some docs to make this more visible. Also updates the step to remove old artifacts after a day or keep current + last artifact in release svn repo.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888110921
All right. Case closed:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888098780
Just to explore it still @kaxil.
I am not convinced what is the best way. I still think we CAN publish index with .yaml with "archives", it's just important what is the timing of this publishing.
From what I saw, the delays of copying "downloads" to "archives" is small (I believe it is less than hour always from earlier discussions). In fact, the release policy of ASF specifically mentions: "downloads.apache.org is automatically archived. Therefore, a copy of an official release will already exist in the archives. To move a release to the archives, just delete the copy in your project's dist directory. Remember to update any links from the download page."
And I think it is in our hands to delay publishing the new `index.yaml` whenever we save chart to the repository. We have two options:
* we could wait with publishing the new index.yaml until "archives" copy is available (and make announcements an hour later).
* we could also make it a "stage" publishing - ie. publish "downloads" link together with SVN update, and automatically replace it with "archives" when the archive copy is available
I think both scenarios provide "uninterrupted" use of helm chart and we can fully automate both of those scenarios. And also the first case ("delay") prevents our users the surprises like https://apache-airflow.slack.com/archives/C027H098M1C/p1627440863116600 where it basically invalidates the old index you already have locally cached. The error message in this case is not telling too much and I think there is a benefit with having the "stable" links to download the charts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888111493
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888108885
> I like this
We could even add a separate step in CI of airlfow-site - to wait until the artifacts are available - in case index.yml change (and send notification via mail or something when they are).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil removed a comment on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
kaxil removed a comment on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888103734
ASF policies are very clear on it:
>Older releases that you no longer recommend to the general public should appear on archive.apache.org/dist/. This site automatically contains all the content of downloads.apache.org/, but nothing is ever deleted. Therefore it should rarely be necessary to touch this site, except during a reorganization. Once your project no longer recommends public use of a particualr release, simply delete it from downloads.apache.org/dist/ by removing it from https://dist.apache.org/repos/dist/release/. It will remain on the archive site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888106178
> @jarek Potiuk The problem I have observed is it takes some more time to sync to archive.
Checking with infra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888098780
Just to explore it still @kaxil.
I am not convinced what is the best way. I still think we CAN publish index with .yaml with "archives", it's just important what is the timing of this publishing.
From what I saw, the delays of copying "downloads" to "archives" is small (I believe it is less than hour always from earlier discussions). In fact, the release policy of ASF specifically mentions: "downloads.apache.org is automatically archived. Therefore, a copy of an official release will already exist in the archives. To move a release to the archives, just delete the copy in your project's dist directory. Remember to update any links from the download page."
And I think it is in our hands to delay publishing the new `index.yaml` whenever we save chart to the repository. We have two options:
* we could wait with publishing the new index.yaml until "archives" copy is available (and make announcements an hour later).
* we could also make it a "stage" publishing - ie. publish "downloads" link together with SVN update, and automatically replace it with "archives" when the archive copy is available
I think both scenarios provide "uninterrupted" use of helm chart and we can fully automate both of those scenarios. And also prevent our users the surprises like https://apache-airflow.slack.com/archives/C027H098M1C/p1627440863116600 where it basically invalidates the old index you already have locally cached. The error message in this case is not telling too much and I think there is a benefit with having the "stable" links to download the charts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888105630
@Jarek Potiuk The problem I have observed is it takes some more time to sync to archive.
>we could wait with publishing the new index.yaml until "archives" copy is available (and make announcements an hour later).
I like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17282:
URL: https://github.com/apache/airflow/pull/17282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17282: Chart: Add instructions to Update Helm Repo before upgrade
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17282:
URL: https://github.com/apache/airflow/pull/17282#issuecomment-888103734
ASF policies are very clear on it:
>Older releases that you no longer recommend to the general public should appear on archive.apache.org/dist/. This site automatically contains all the content of downloads.apache.org/, but nothing is ever deleted. Therefore it should rarely be necessary to touch this site, except during a reorganization. Once your project no longer recommends public use of a particualr release, simply delete it from downloads.apache.org/dist/ by removing it from https://dist.apache.org/repos/dist/release/. It will remain on the archive site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org