You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 09:06:16 UTC
[GitHub] [arrow] amol- opened a new pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
amol- opened a new pull request #10159:
URL: https://github.com/apache/arrow/pull/10159
Second batch of changes related to making pyarrow build more modular. `hdfs-io` is no longer included in `pyarrow.lib` but has been separated to its own module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828279769
As you can see, it's deprecated, so I'm not sure it's worth doing this. @jorisvandenbossche What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828299602
Since this shouldn't have any impact on the usage, I am personally fine with already moving it out from pyarrow.lib, even though it is deprecated. It already gives the benefit of no longer having it in lib, and is still easy to completely remove once we want to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
amol- commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828278853
Rebased on master after the first PR has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10159:
URL: https://github.com/apache/arrow/pull/10159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828297975
@github-actions crossbow submit test-conda-python-3.7-hdfs-3.2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
amol- commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828295659
> As you can see, it's deprecated, so I'm not sure it's worth doing this. @jorisvandenbossche What do you think?
Well, while it's still around it provides a benefit and I think that separating it into its own module will also make easier to remove it once we actually want to remove it.
If we plan to remove it in 5.0 I can also change this PR to remove it. In the end my goal was to speed up time it takes to recompile pyarrow and both separating it and removing it will achieve that goal :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#discussion_r622021182
##########
File path: python/CMakeLists.txt
##########
@@ -391,7 +391,8 @@ set(CYTHON_EXTENSIONS
_compute
_csv
_feather
- _json)
+ _json
+ _hdfsio)
Review comment:
Nit, but can you keep alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-826654778
https://issues.apache.org/jira/browse/ARROW-12506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on a change in pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
amol- commented on a change in pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#discussion_r622814559
##########
File path: python/CMakeLists.txt
##########
@@ -391,7 +391,8 @@ set(CYTHON_EXTENSIONS
_compute
_csv
_feather
- _json)
+ _json
+ _hdfsio)
Review comment:
Sorted alphabetically. Also there was `_fs` that was before `_compute` and thus moved that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10159: ARROW-12506: [Python] Improve modularity of pyarrow codebase: _hdfsio module
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10159:
URL: https://github.com/apache/arrow/pull/10159#issuecomment-828303374
Revision: b7ddf68f8dfd6e9412d9680ebb63dd6573195048
Submitted crossbow builds: [ursacomputing/crossbow @ actions-350](https://github.com/ursacomputing/crossbow/branches/all?query=actions-350)
|Task|Status|
|----|------|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-350-github-test-conda-python-3.7-hdfs-3.2.1)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org