You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:43:33 UTC
[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request, #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Ted-Jiang opened a new pull request, #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965
…me, record output, etc (#63)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2961
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#issuecomment-1195160019
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2965](https://codecov.io/gh/apache/arrow-datafusion/pull/2965?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (585834d) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/834924f274d9e04444030b8eb3e07e1035fcd3cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (834924f) will **increase** coverage by `0.22%`.
> The diff coverage is `95.45%`.
```diff
@@ Coverage Diff @@
## master #2965 +/- ##
==========================================
+ Coverage 85.43% 85.65% +0.22%
==========================================
Files 275 279 +4
Lines 49839 51093 +1254
==========================================
+ Hits 42578 43766 +1188
- Misses 7261 7327 +66
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...afusion/core/src/physical\_plan/file\_format/avro.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L2F2cm8ucnM=) | `0.00% <0.00%> (ø)` | |
| [...tafusion/core/src/physical\_plan/file\_format/csv.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L2Nzdi5ycw==) | `94.47% <100.00%> (+0.10%)` | :arrow_up: |
| [.../core/src/physical\_plan/file\_format/file\_stream.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L2ZpbGVfc3RyZWFtLnJz) | `90.47% <100.00%> (+0.57%)` | :arrow_up: |
| [...afusion/core/src/physical\_plan/file\_format/json.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L2pzb24ucnM=) | `93.93% <100.00%> (+0.12%)` | :arrow_up: |
| [...sion/core/src/physical\_plan/file\_format/parquet.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2ZpbGVfZm9ybWF0L3BhcnF1ZXQucnM=) | `95.02% <100.00%> (+0.01%)` | :arrow_up: |
| [datafusion/optimizer/src/test/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3Rlc3QvbW9kLnJz) | `94.23% <0.00%> (-5.77%)` | :arrow_down: |
| [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `92.43% <0.00%> (-0.85%)` | :arrow_down: |
| [datafusion/optimizer/src/reduce\_outer\_join.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3JlZHVjZV9vdXRlcl9qb2luLnJz) | `98.79% <0.00%> (-0.61%)` | :arrow_down: |
| [datafusion/core/tests/sql/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9tb2QucnM=) | `98.26% <0.00%> (-0.56%)` | :arrow_down: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/arrow-datafusion/pull/2965/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#issuecomment-1197103246
Thanks @Ted-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#issuecomment-1195385915
@alamb PTAL 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#discussion_r931340354
##########
datafusion/core/src/physical_plan/file_format/avro.rs:
##########
@@ -24,17 +24,23 @@ use crate::physical_plan::{
use arrow::datatypes::SchemaRef;
use crate::execution::context::TaskContext;
+#[cfg(feature = "avro")]
+use crate::physical_plan::metrics::BaselineMetrics;
+use crate::physical_plan::metrics::ExecutionPlanMetricsSet;
use std::any::Any;
use std::sync::Arc;
use super::FileScanConfig;
/// Execution plan for scanning Avro data source
#[derive(Debug, Clone)]
+#[allow(dead_code)]
Review Comment:
Not sure why this is needed
##########
datafusion/core/src/physical_plan/file_format/avro.rs:
##########
@@ -24,17 +24,23 @@ use crate::physical_plan::{
use arrow::datatypes::SchemaRef;
use crate::execution::context::TaskContext;
+#[cfg(feature = "avro")]
Review Comment:
Isn't this whole file `#[cfg(feature = "avro")]` ?
In other words, would this work?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965#issuecomment-1197112993
Benchmark runs are scheduled for baseline = e47c4eb1ac8a5c3c07a0ed2bad74ecd6509bae7b and contender = 16f89346fc4bdc9e99b6c96cb54e8a2424fda091. 16f89346fc4bdc9e99b6c96cb54e8a2424fda091 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b1f3bb703691492cbc23f880d7bf95a7...16b9579af6764e1891dde5a19753a655/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bb159ddf978241edbbc971ddb8ef70c1...bcaab6de2557465284ab48faa604dc24/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e4e477d00e264d3ca20ca1f21b232c04...b5b59d0ef54440369993c825a5560617/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9b14d8dc0da1491384e198ec054ac3d8...49ae8f3b06eb46e882d45f5bd7e2d259/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2965: Add baseline_metrics for FileStream to record metrics like elapsed ti…
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2965:
URL: https://github.com/apache/arrow-datafusion/pull/2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org