You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/09/14 14:08:14 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #2590: IGNITE-20417 Get rid of unused code in the index module
tkalkirill opened a new pull request, #2590:
URL: https://github.com/apache/ignite-3/pull/2590
https://issues.apache.org/jira/browse/IGNITE-20417
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326014239
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -215,22 +217,21 @@ private CompletableFuture<Boolean> onIndexCreate(CreateIndexEventParameters para
private CompletableFuture<Void> createIndexLocally(
long causalityToken,
+ int catalogVersion,
CatalogTableDescriptor table,
CatalogIndexDescriptor index
) {
int tableId = table.id();
int indexId = index.id();
- if (LOG.isInfoEnabled()) {
Review Comment:
Why did you remove this check?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java:
##########
@@ -53,6 +53,8 @@ public void eventsAreFiredWhenIndexesCreatedAndDropped() {
String tableName = "TNAME";
+ int catalogVersion = ((IgniteImpl) ignite).catalogManager().latestCatalogVersion();
Review Comment:
Maybe we should do the `(IgniteImpl)` cast to the first line of this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326051334
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -215,22 +217,21 @@ private CompletableFuture<Boolean> onIndexCreate(CreateIndexEventParameters para
private CompletableFuture<Void> createIndexLocally(
long causalityToken,
+ int catalogVersion,
CatalogTableDescriptor table,
CatalogIndexDescriptor index
) {
int tableId = table.id();
int indexId = index.id();
- if (LOG.isInfoEnabled()) {
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326041602
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -215,22 +217,21 @@ private CompletableFuture<Boolean> onIndexCreate(CreateIndexEventParameters para
private CompletableFuture<Void> createIndexLocally(
long causalityToken,
+ int catalogVersion,
CatalogTableDescriptor table,
CatalogIndexDescriptor index
) {
int tableId = table.id();
int indexId = index.id();
- if (LOG.isInfoEnabled()) {
Review Comment:
we have a lot of these checks all over the code, I'd prefer to keep the code consistent. It is also not related, so please revert it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326026089
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -215,22 +217,21 @@ private CompletableFuture<Boolean> onIndexCreate(CreateIndexEventParameters para
private CompletableFuture<Void> createIndexLocally(
long causalityToken,
+ int catalogVersion,
CatalogTableDescriptor table,
CatalogIndexDescriptor index
) {
int tableId = table.id();
int indexId = index.id();
- if (LOG.isInfoEnabled()) {
Review Comment:
This is not a hot path, I just find it more beautiful this way, checking happens inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590#discussion_r1326023440
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/index/ItIndexManagerTest.java:
##########
@@ -53,6 +53,8 @@ public void eventsAreFiredWhenIndexesCreatedAndDropped() {
String tableName = "TNAME";
+ int catalogVersion = ((IgniteImpl) ignite).catalogManager().latestCatalogVersion();
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill merged pull request #2590: IGNITE-20417 Get rid of unused code in the index module
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #2590:
URL: https://github.com/apache/ignite-3/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org