You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/27 07:25:42 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9851: Split TCP related service mesh metrics protobuffer definition

wu-sheng commented on code in PR #9851:
URL: https://github.com/apache/skywalking/pull/9851#discussion_r1006495762


##########
oap-server/server-starter/src/main/resources/oal/core.oal:
##########
@@ -16,9 +16,6 @@
  *
  */
 
-// For services using protocols HTTP 1/2, gRPC, RPC, etc., the cpm metrics means "calls per minute",
-// for services that are built on top of TCP, the cpm means "packages per minute".
-

Review Comment:
   I remember we had some UI dashboards mentioning these too. Could you recheck?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org