You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/03/03 08:22:08 UTC

[GitHub] [buildstream] gtristan commented on pull request #1447: Completely remove the pipe between the parent and the child subprocess

gtristan commented on pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447#issuecomment-789531138


   I concur, I stared the patch quite hard in the face and it appears correct to me.
   
   I am still a little curious about how success/fail/error status of child jobs is communicated in the absence of our pipe, but this appears to have all changed in the main previous patch which moves to a threaded scheduler, so it is irrelevant here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org