You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2016/04/14 21:29:24 UTC
Review Request 46219: AMBARI-15892 : Incorrect (Negative) values are
shown for memory metrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/
-----------------------------------------------------------
Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-15892
https://issues.apache.org/jira/browse/AMBARI-15892
Repository: ambari
Description
-------
Issue
In the "NameNode HostLoad" graph, the negative values are seen for the computed metric "Memory Utilization" which goes by the formula :
( mem_total - (mem_free + mem_cache) ) *100 / mem_total
Bug
AMBARI-15448 changed the way memory metrics are being reported to AMS. This lead to a double subtraction of mem_cached, thereby leading to a negative value intermittently.
Fix
Change the widget to :
( mem_total - mem_free ) *100 / mem_total
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 0476326
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 0f8f105
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json a19a112
Diff: https://reviews.apache.org/r/46219/diff/
Testing
-------
Unit tests pass.
Manual widget testing done.
Manual upgrade testing pending.
Thanks,
Aravindan Vijayan
Re: Review Request 46219: AMBARI-15892 : Incorrect (Negative) values
are shown for memory metrics
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46219/#review128966
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On April 14, 2016, 7:29 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46219/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:29 p.m.)
>
>
> Review request for Ambari, Andrii Tkach, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-15892
> https://issues.apache.org/jira/browse/AMBARI-15892
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Issue
> In the "NameNode HostLoad" graph, the negative values are seen for the computed metric "Memory Utilization" which goes by the formula :
> ( mem_total - (mem_free + mem_cache) ) *100 / mem_total
>
> Bug
> AMBARI-15448 changed the way memory metrics are being reported to AMS. This lead to a double subtraction of mem_cached, thereby leading to a negative value intermittently.
>
> Fix
> Change the widget to :
> ( mem_total - mem_free ) *100 / mem_total
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java 0476326
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 0f8f105
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json a19a112
>
> Diff: https://reviews.apache.org/r/46219/diff/
>
>
> Testing
> -------
>
> Unit tests pass.
>
> Manual widget testing done.
>
> Manual upgrade testing pending.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>