[GitHub] [ignite-3] zstan commented on a diff in pull request #1043: IGNITE-17580: Deprecate SchemaBuilder public API

[GitBox <gi...@apache.org>]

zstan commented on code in PR #1043:
URL: https://github.com/apache/ignite-3/pull/1043#discussion_r959247857


##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/SchemaUtils.java:
##########
@@ -143,4 +144,13 @@ public static boolean equalSchemas(SchemaDescriptor exp, SchemaDescriptor actual
 
         return true;
     }
+
+    /**
+     * Creates canonical table name.
+     *
+     * @return Table with schema canonical name.
+     */
+    public static String canonicalName(@NotNull String schema, @NotNull String name) {

Review Comment:
   Sorry but ... rules are so )
   https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide
   2 Nullability annotation usages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org