You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "collinmcnulty (via GitHub)" <gi...@apache.org> on 2023/04/07 17:04:30 UTC
[GitHub] [airflow] collinmcnulty opened a new issue, #30526: Google vendored-in googleads missed one import
collinmcnulty opened a new issue, #30526:
URL: https://github.com/apache/airflow/issues/30526
### Apache Airflow Provider(s)
google
### Versions of Apache Airflow Providers
8.12.0
### Apache Airflow version
2.5.3
### Operating System
Debian GNU/Linux 11 (bullseye)
### Deployment
Astronomer
### Deployment details
Using the Astro CLI. I can provide full requirements.txt if needed.
### What happened
Using the latest google provider to access v13 of Google Ads API, but calls are blocked saying that `Specified Google Ads API version "v13" does not exist. Valid API versions are: "v13", "v12", "v11"`
### What you think should happen instead
Calls to the API should go through without error. This vendored version, does, I believe, allow v13, but is using an outdated check because the check is importing the older, non-vendored-in googleads package.
### How to reproduce
```
>>> from airflow.providers.google_vendor.googleads.client import GoogleAdsClient
>>> GoogleAdsClient._get_api_services_by_version("v13")
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/airflow/providers/google_vendor/googleads/client.py", line 203, in _get_api_services_by_version
version_module = import_module(f"airflow.providers.google_vendor.googleads.{version}")
File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 984, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'airflow.providers.google_vendor.googleads.v13'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python3.9/site-packages/airflow/providers/google_vendor/googleads/client.py", line 205, in _get_api_services_by_version
raise ValueError(
ValueError: Specified Google Ads API version "v13" does not exist. Valid API versions are: "v13", "v12", "v11"
```
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #30526: Google vendored-in googleads missed one import
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #30526:
URL: https://github.com/apache/airflow/issues/30526#issuecomment-1500476916
cc @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cpsenka commented on issue #30526: Google vendored-in googleads missed one import
Posted by "cpsenka (via GitHub)" <gi...@apache.org>.
cpsenka commented on issue #30526:
URL: https://github.com/apache/airflow/issues/30526#issuecomment-1500481748
Should just need to update `version_module = import_module(f"google.ads.googleads.{version}")` to `version_module = import_module(f"airflow.providers.google.ads._vendor.googleads.{version}")` here: https://github.com/apache/airflow/blob/main/airflow/providers/google/ads/_vendor/googleads/client.py#L203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #30526: Google vendored-in googleads missed one import
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #30526:
URL: https://github.com/apache/airflow/issues/30526#issuecomment-1500495955
As discussed in slack https://github.com/apache/airflow/pull/30468 this version has I think more than that fixed and i would love to get this one tested as i am unable to test it with real ads avcount
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #30526: Google vendored-in googleads missed one import
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #30526: Google vendored-in googleads missed one import
URL: https://github.com/apache/airflow/issues/30526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org