You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/15 14:22:42 UTC

[GitHub] [apisix-ingress-controller] stillfox-lee commented on a diff in pull request #1158: test: keep namespace when test failed in dev mod

stillfox-lee commented on code in PR #1158:
URL: https://github.com/apache/apisix-ingress-controller/pull/1158#discussion_r922216350


##########
test/e2e/scaffold/scaffold.go:
##########
@@ -442,6 +442,8 @@ func (s *Scaffold) beforeEach() {
 func (s *Scaffold) afterEach() {
 	defer ginkgo.GinkgoRecover()
 
+	shouldKeepNamespace := false
+
 	if ginkgo.CurrentSpecReport().Failed() {

Review Comment:
   Is three any situation we still need real-time information from the namespace? Sometimes e2e-test may spend over an hour. Some resources like `Event` might be deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org