You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/07 11:26:00 UTC

[GitHub] [camel-k] davsclaus opened a new issue #2815: KameletBinding - Make error handler more simpler

davsclaus opened a new issue #2815:
URL: https://github.com/apache/camel-k/issues/2815


   A binding is intended to be high level and fairly simple.
   https://camel.apache.org/camel-k/1.7.x/kamelets/kameletbindings-error-handler.html
   
   I wonder if we have not made the error handler a bit too complex with the `bean` and `ref`. What is the purpose of those. As they require the user to implement a custom error handler builder (which nobody really does in core camel).
   
   I wonder if we can deprecate and remove those, or did you find a use-case for them somehow in camel-k?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez closed issue #2815: KameletBinding - Make error handler more simpler

Posted by GitBox <gi...@apache.org>.
squakez closed issue #2815:
URL: https://github.com/apache/camel-k/issues/2815


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] davsclaus commented on issue #2815: KameletBinding - Make error handler more simpler

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #2815:
URL: https://github.com/apache/camel-k/issues/2815#issuecomment-987835877


   @squakez any thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez commented on issue #2815: KameletBinding - Make error handler more simpler

Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2815:
URL: https://github.com/apache/camel-k/issues/2815#issuecomment-987855101


   Yeah, I think the direct usage of them can be hidden to the final user, but cannot be removed (at least `ref`) as it's the foundation of the feature itself (see https://github.com/apache/camel-k/blob/2ef783640db6c2cb57661cf944fc67360e767dc0/pkg/trait/error_handler.go#L97). When I developed originally the feature, I exposed all the low level implementations to collect feedback on possible advanced use case. I don't see any added value to the user, so, I agree we can remove the option. Also @lburgazzoli was involved on the design, maybe he had in mind some other use case I ignore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org