[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4458: [Quantization] Fix annotation for multiply op

[GitBox <gi...@apache.org>]

vinx13 commented on a change in pull request #4458: [Quantization] Fix annotation for multiply op
URL: https://github.com/apache/incubator-tvm/pull/4458#discussion_r356779890
 
 

 ##########
 File path: src/relay/pass/quantize/realize.cc
 ##########
 @@ -278,13 +278,9 @@ Expr MulRealize(const Call& ref_call,
     DataType dtype = cfg->dtype_activation;
     if (lhs->dtype != dtype) {
       ldata = Cast(ldata, dtype);
-    } else {
-      CHECK_EQ(lhs->dtype, dtype);
     }
     if (rhs->dtype != dtype) {
       rdata = Cast(rdata, dtype);
-    } else {
-      CHECK_EQ(rhs->dtype, dtype);
     }
 
 Review comment:
   this check seems very trivial... @ZihengJiang ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services