You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Robert Scholte <rf...@apache.org> on 2013/11/16 16:49:35 UTC
prepare maven-ear-plugin 2.9
Hi,
I'd like to release this plugin the coming week. If there are issues you'd
like to fix for this release, let me know so I can wait until these fixes
are added.
Robert
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: prepare maven-ear-plugin 2.9
Posted by Robert Scholte <rf...@apache.org>.
If I'm correct, "required" should be read as: if this value has no default
value or is explicitly set to null, the plugin will fail.
However, this is something which I've never tested. That would be nice as
part of the plugin testing harness.
I'm not planning to change this right now.
Robert
Op Mon, 18 Nov 2013 13:43:58 +0100 schreef Stephane Nicoll
<st...@gmail.com>:
> Honestly, I don't really see the problem. Looking at the latest
> release[1],
> there are 4 required parameters indeed but the default value is defined
> (in
> bold). I don't think this is specific to the EAR plugin actually: the jar
> plugin has exactly the same kind of doc! [2]
>
> Maybe the required parameters that have a default value should be
> rendered
> differently. I can't really tell what we should do as I am not confused.
>
> Thanks,
> S.
>
> [1] http://maven.apache.org/plugins/maven-ear-plugin/ear-mojo.html
> [2] http://maven.apache.org/plugins/maven-jar-plugin/jar-mojo.html
>
>
> On Mon, Nov 18, 2013 at 1:39 PM, Anders Hammar <an...@hammar.net> wrote:
>
>> One thing I've been confused about in the plugin docs is "Required
>> Parameters" in the goal's page. For example here:
>>
>> C:\Users\KAHA14\workspace_juno_svnkit\maven-ear-plugin\target\site\ear-mojo.html
>>
>> Trying to think as a novice user I would assume that I would need to
>> configured all of the "required parameters". But in this case they
>> already
>> have defautl values, so I don't have to configure them. So are they
>> really
>> required?
>> The problem here, I think, is that the technical "required" flag of the
>> annotation is translated into the user perspective docs which is not
>> correct if it has a default value.
>>
>> So, to bring this back to the topic of this thread, is this something
>> that
>> should be fixed in the ear plugin (remove the required=true from these
>> params), or is it something that should be fixed in m-plugin-plugin?
>>
>> /Anders
>>
>>
>> On Sat, Nov 16, 2013 at 4:49 PM, Robert Scholte <rfscholte@apache.org
>> >wrote:
>>
>> > Hi,
>> >
>> > I'd like to release this plugin the coming week. If there are issues
>> you'd
>> > like to fix for this release, let me know so I can wait until these
>> fixes
>> > are added.
>> >
>> > Robert
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>> >
>> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: prepare maven-ear-plugin 2.9
Posted by Stephane Nicoll <st...@gmail.com>.
Honestly, I don't really see the problem. Looking at the latest release[1],
there are 4 required parameters indeed but the default value is defined (in
bold). I don't think this is specific to the EAR plugin actually: the jar
plugin has exactly the same kind of doc! [2]
Maybe the required parameters that have a default value should be rendered
differently. I can't really tell what we should do as I am not confused.
Thanks,
S.
[1] http://maven.apache.org/plugins/maven-ear-plugin/ear-mojo.html
[2] http://maven.apache.org/plugins/maven-jar-plugin/jar-mojo.html
On Mon, Nov 18, 2013 at 1:39 PM, Anders Hammar <an...@hammar.net> wrote:
> One thing I've been confused about in the plugin docs is "Required
> Parameters" in the goal's page. For example here:
>
> C:\Users\KAHA14\workspace_juno_svnkit\maven-ear-plugin\target\site\ear-mojo.html
>
> Trying to think as a novice user I would assume that I would need to
> configured all of the "required parameters". But in this case they already
> have defautl values, so I don't have to configure them. So are they really
> required?
> The problem here, I think, is that the technical "required" flag of the
> annotation is translated into the user perspective docs which is not
> correct if it has a default value.
>
> So, to bring this back to the topic of this thread, is this something that
> should be fixed in the ear plugin (remove the required=true from these
> params), or is it something that should be fixed in m-plugin-plugin?
>
> /Anders
>
>
> On Sat, Nov 16, 2013 at 4:49 PM, Robert Scholte <rfscholte@apache.org
> >wrote:
>
> > Hi,
> >
> > I'd like to release this plugin the coming week. If there are issues
> you'd
> > like to fix for this release, let me know so I can wait until these fixes
> > are added.
> >
> > Robert
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
Re: prepare maven-ear-plugin 2.9
Posted by Anders Hammar <an...@hammar.net>.
One thing I've been confused about in the plugin docs is "Required
Parameters" in the goal's page. For example here:
C:\Users\KAHA14\workspace_juno_svnkit\maven-ear-plugin\target\site\ear-mojo.html
Trying to think as a novice user I would assume that I would need to
configured all of the "required parameters". But in this case they already
have defautl values, so I don't have to configure them. So are they really
required?
The problem here, I think, is that the technical "required" flag of the
annotation is translated into the user perspective docs which is not
correct if it has a default value.
So, to bring this back to the topic of this thread, is this something that
should be fixed in the ear plugin (remove the required=true from these
params), or is it something that should be fixed in m-plugin-plugin?
/Anders
On Sat, Nov 16, 2013 at 4:49 PM, Robert Scholte <rf...@apache.org>wrote:
> Hi,
>
> I'd like to release this plugin the coming week. If there are issues you'd
> like to fix for this release, let me know so I can wait until these fixes
> are added.
>
> Robert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>