[GitHub] [activemq-nms-amqp] cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit

[GitBox <gi...@apache.org>]

cjwmorgan-sol commented on issue #9: [PoC] Testing toolkit
URL: https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-516028082
 
 
   Improving integration tests is a great idea. 
   For the changes to fix issue 1. I noticed that the closed callback for sessions does not remove the amqpSession from the amqpConnection, unlike amqpComsumer. Removing the explicit call to close would leave references in the amqpConnection list for its amqpSessions. 
   For issue 2. NMSConnectionExceptions should be produced instead of IllegalStateExceptions on remote connection failures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services