[GitHub] [hbase] saintstack commented on a change in pull request #2580: HBASE-25210 RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2580:
URL: https://github.com/apache/hbase/pull/2580#discussion_r513163262



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MutableRegionInfo.java
##########
@@ -254,8 +254,10 @@ public MutableRegionInfo setSplit(boolean split) {
 
   /**
    * @return True if this region is offline.
+   * @deprecated since 3.0.0 and will be removed in 4.0.0

Review comment:
       What @Apache9 said..... say, is only used when we split a region so split == offline.

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java
##########
@@ -218,12 +218,16 @@
 
   /**
    * @return True if this region is offline.
+   * @deprecated since 3.0.0 and will be removed in 4.0.0
    */
+  @Deprecated
   boolean isOffline();
 
   /**
    * @return True if this is a split parent region.
+   * @deprecated since 3.0.0 and will be removed in 4.0.0

Review comment:
       Should folks use isSplit instead? If so say so in the @deprecated ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org