You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2013/08/27 00:39:03 UTC
[jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 deasync-vcloud
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/125
-- Commit Summary --
* Removing async from vcloud and Terremark APIs/providers
-- File Changes --
R apis/vcloud/src/main/java/org/jclouds/vcloud/VCloudApi.java (37)
M apis/vcloud/src/main/java/org/jclouds/vcloud/VCloudApiMetadata.java (26)
D apis/vcloud/src/main/java/org/jclouds/vcloud/VCloudAsyncClient.java (119)
R apis/vcloud/src/main/java/org/jclouds/vcloud/VCloudVersionsApi.java (12)
D apis/vcloud/src/main/java/org/jclouds/vcloud/VCloudVersionsAsyncClient.java (47)
M apis/vcloud/src/main/java/org/jclouds/vcloud/compute/strategy/InstantiateVAppTemplateWithGroupEncodedIntoNameThenCustomizeDeployAndPowerOn.java (6)
M apis/vcloud/src/main/java/org/jclouds/vcloud/compute/strategy/VCloudComputeServiceAdapter.java (9)
R apis/vcloud/src/main/java/org/jclouds/vcloud/config/VCloudHttpApiModule.java (60)
A apis/vcloud/src/main/java/org/jclouds/vcloud/features/CatalogApi.java (145)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/CatalogAsyncClient.java (121)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/CatalogClient.java (86)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/NetworkApi.java (25)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/NetworkClient.java (33)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/OrgApi.java (31)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/OrgClient.java (54)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/TaskApi.java (38)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/TaskClient.java (48)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/VAppApi.java (142)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/VAppAsyncClient.java (219)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/VAppTemplateApi.java (132)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/VAppTemplateClient.java (97)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/VDCApi.java (29)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/VDCClient.java (44)
R apis/vcloud/src/main/java/org/jclouds/vcloud/features/VmApi.java (150)
D apis/vcloud/src/main/java/org/jclouds/vcloud/features/VmAsyncClient.java (230)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/CatalogItemsInCatalog.java (22)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/CatalogsInOrg.java (20)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/NetworksInOrg.java (20)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/OrgsForLocations.java (20)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/OrgsForNames.java (20)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/VAppTemplatesForCatalogItems.java (22)
M apis/vcloud/src/main/java/org/jclouds/vcloud/functions/VDCsInOrg.java (20)
R apis/vcloud/src/main/java/org/jclouds/vcloud/internal/VCloudLoginApi.java (13)
D apis/vcloud/src/main/java/org/jclouds/vcloud/internal/VCloudLoginClient.java (26)
M apis/vcloud/src/main/java/org/jclouds/vcloud/loaders/OVFLoader.java (6)
M apis/vcloud/src/main/java/org/jclouds/vcloud/loaders/VAppTemplateLoader.java (6)
M apis/vcloud/src/main/java/org/jclouds/vcloud/predicates/TaskSuccess.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/VCloudApiTest.java (25)
M apis/vcloud/src/test/java/org/jclouds/vcloud/VCloudSessionRefreshLiveTest.java (7)
R apis/vcloud/src/test/java/org/jclouds/vcloud/VCloudVersionsApiTest.java (12)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/CatalogApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/CatalogApiTest.java (18)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/NetworkApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/NetworkApiTest.java (12)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/OrgApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/OrgApiTest.java (14)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/TaskApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/TaskApiTest.java (16)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VAppApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VAppApiTest.java (38)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VAppTemplateApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VAppTemplateApiTest.java (28)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VDCApiLiveTest.java (6)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VDCApiTest.java (18)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VmApiLiveTest.java (12)
R apis/vcloud/src/test/java/org/jclouds/vcloud/features/VmApiTest.java (38)
R apis/vcloud/src/test/java/org/jclouds/vcloud/internal/BaseVCloudApiLiveTest.java (11)
R apis/vcloud/src/test/java/org/jclouds/vcloud/internal/BaseVCloudApiTest.java (22)
R apis/vcloud/src/test/java/org/jclouds/vcloud/internal/VCloudLoginApiTest.java (12)
A common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/TerremarkVCloudApi.java (576)
D common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/TerremarkVCloudAsyncClient.java (547)
D common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/TerremarkVCloudClient.java (313)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/TerremarkVCloudComputeClient.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/functions/CreateUniqueKeyPair.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/functions/NodeMetadataToOrgAndName.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/DeleteKeyPair.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/TerremarkVCloudGetImageStrategy.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/TerremarkVCloudGetNodeMetadataStrategy.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/TerremarkVCloudLifeCycleStrategy.java (6)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/TerremarkVCloudListNodesStrategy.java (7)
R common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/config/TerremarkVCloudHttpApiModule.java (32)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/AllCatalogItemsInCatalog.java (23)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/AllCatalogsInOrg.java (26)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/AllVDCsInOrg.java (26)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/OrgsForLocations.java (21)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/OrgsForNames.java (20)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/VAppTemplatesForCatalogItems.java (22)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/functions/VAppTemplatesForResourceEntities.java (22)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudApiMetadata.java (12)
R common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudLoginApi.java (17)
D common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudLoginClient.java (26)
R common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudVersionsApi.java (12)
D common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudVersionsAsyncClient.java (47)
M common/trmk/src/main/java/org/jclouds/trmk/vcloud_0_8/predicates/TaskSuccess.java (6)
R common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/TerremarkApiLiveTest.java (20)
M common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/compute/TerremarkVCloudComputeClientTest.java (4)
M common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/compute/strategy/DeleteKeyPairTest.java (4)
M common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/compute/suppliers/VAppTemplatesInOrgsLiveTest.java (6)
R common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/internal/BaseTerremarkApiLiveTest.java (10)
R common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudLoginApiTest.java (12)
R common/trmk/src/test/java/org/jclouds/trmk/vcloud_0_8/internal/TerremarkVCloudVersionsApiTest.java (10)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01CatalogApiLiveTest.java (8)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01NetworkApiLiveTest.java (8)
D providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01NetworkClientLiveTest.java (33)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01OrgApiLiveTest.java (8)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01TaskApiLiveTest.java (8)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01VAppApiLiveTest.java (8)
R providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01VAppTemplateApiLiveTest.java (8)
D providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01VAppTemplateClientLiveTest.java (33)
A providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01VDCApiLiveTest.java (33)
A providers/bluelock-vcloud-zone01/src/test/java/org/jclouds/bluelock/vcloud/zone01/features/BluelockVCloudZone01VmApiLiveTest.java (33)
M providers/greenhousedata-element-vcloud/src/main/java/org/jclouds/greenhousedata/element/vcloud/GreenHouseDataElementVCloudProviderMetadata.java (4)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudCatalogApiLiveTest.java (8)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudNetworkApiLiveTest.java (8)
D providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudNetworkClientLiveTest.java (33)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudOrgApiLiveTest.java (8)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudTaskApiLiveTest.java (8)
A providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudVAppApiLiveTest.java (33)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudVAppTemplateApiLiveTest.java (8)
D providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudVAppTemplateClientLiveTest.java (33)
A providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudVDCApiLiveTest.java (33)
R providers/greenhousedata-element-vcloud/src/test/java/org/jclouds/greenhousedata/element/vcloud/features/GreenHouseDataElementVCloudVmApiLiveTest.java (8)
R providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/TerremarkECloudApi.java (178)
M providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/TerremarkECloudApiMetadata.java (17)
D providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/TerremarkECloudClient.java (90)
R providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/config/TerremarkECloudHttpApiModule.java (40)
R providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/features/DataCenterOperationsApi.java (38)
D providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/features/DataCenterOperationsClient.java (52)
R providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/features/TagOperationsApi.java (31)
D providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/features/TagOperationsClient.java (44)
M providers/trmk-ecloud/src/main/java/org/jclouds/trmk/ecloud/suppliers/TerremarkECloudInternetServiceAndPublicIpAddressSupplier.java (6)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/BaseTerremarkECloudApiLiveTest.java (8)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/BaseTerremarkECloudApiTest.java (16)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/TerremarkECloudApiLiveTest.java (12)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/TerremarkECloudApiTest.java (62)
M providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/TerremarkECloudClientMockTest.java (6)
M providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/compute/TerremarkECloudComputeServiceLiveTest.java (4)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/features/DataCenterOperationsApiLiveTest.java (10)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/features/DataCenterOperationsApiTest.java (14)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/features/TagOperationsApiLiveTest.java (10)
R providers/trmk-ecloud/src/test/java/org/jclouds/trmk/ecloud/features/TagOperationsApiTest.java (12)
R providers/trmk-vcloudexpress/src/main/java/org/jclouds/trmk/vcloudexpress/TerremarkVCloudExpressApi.java (92)
M providers/trmk-vcloudexpress/src/main/java/org/jclouds/trmk/vcloudexpress/TerremarkVCloudExpressApiMetadata.java (16)
D providers/trmk-vcloudexpress/src/main/java/org/jclouds/trmk/vcloudexpress/TerremarkVCloudExpressClient.java (37)
R providers/trmk-vcloudexpress/src/main/java/org/jclouds/trmk/vcloudexpress/config/TerremarkVCloudExpressHttpApiModule.java (20)
M providers/trmk-vcloudexpress/src/main/java/org/jclouds/trmk/vcloudexpress/suppliers/TerremarkVCloudExpressInternetServiceAndPublicIpAddressSupplier.java (6)
M providers/trmk-vcloudexpress/src/test/java/org/jclouds/trmk/vcloudexpress/InternetServiceLiveTest.java (6)
R providers/trmk-vcloudexpress/src/test/java/org/jclouds/trmk/vcloudexpress/TerremarkVCloudExpressApiLiveTest.java (10)
R providers/trmk-vcloudexpress/src/test/java/org/jclouds/trmk/vcloudexpress/TerremarkVCloudExpressApiTest.java (78)
M providers/trmk-vcloudexpress/src/test/java/org/jclouds/trmk/vcloudexpress/compute/TerremarkVCloudExpressComputeServiceLiveTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/125.patch
https://github.com/jclouds/jclouds/pull/125.diff
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #645](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/645/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23372979
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Bayer <no...@github.com>.
> /**
> * Provides asynchronous access to VApp Template features.
> *
> */
> @Delegate
> - VAppTemplateClient getVAppTemplateClient();
> + VAppTemplateApi getVAppTemplateClient();
Touché. I'll do that.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125/files#r6074424
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Phillips <no...@github.com>.
> so please don't guilt me into rewriting the vcloud support... =)
Ah, a preemptive strike! ;-) I'll try my best. Certainly BuildHive and DEV@cloud are in your favour ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23305657
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #343](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/343/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23303009
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #171](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/171/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23303341
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Bayer <no...@github.com>.
> /**
> * Provides asynchronous access to VApp Template features.
> *
> */
> @Delegate
> - VAppTemplateClient getVAppTemplateClient();
> + VAppTemplateApi getVAppTemplateClient();
Fixed, pushed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125/files#r6074622
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Bayer <no...@github.com>.
Also note that there'll be a complementary PR on 1.6.x for deprecating *Client and adding shim *Api classes, same as I've done before.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23305679
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #172](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/172/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23305365
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Phillips <no...@github.com>.
> /**
> * Provides asynchronous access to VApp Template features.
> *
> */
> @Delegate
> - VAppTemplateClient getVAppTemplateClient();
> + VAppTemplateApi getVAppTemplateClient();
Should these getters also be renamed to `get...Api()`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125/files#r6073831
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Bayer <no...@github.com>.
Note to @demobox: Yes, there's a lot of deeply ugly shit here. I swear I just cut and pasted it around, so please don't guilt me into rewriting the vcloud support... =)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23302600
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #632](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/632/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23305362
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #184](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/184/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23372989
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by Andrew Phillips <no...@github.com>.
> @@ -79,7 +79,7 @@
>
>
> @Inject
> - protected InstantiateVAppTemplateWithGroupEncodedIntoNameThenCustomizeDeployAndPowerOn(VCloudClient client,
> + protected InstantiateVAppTemplateWithGroupEncodedIntoNameThenCustomizeDeployAndPowerOn(VCloudApi client,
> Predicate<URI> successTester, LoadingCache<URI, VAppTemplate> vAppTemplates, NetworkConfigurationForNetworkAndOptions networkConfigurationForNetworkAndOptions,
> @BuildVersion String buildVersion) {
> this.client = client;
What's our plan for variables like these. Rename to `api` too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125/files#r6074806
Re: [jclouds] Removing async from vcloud and Terremark APIs/providers
(#125)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #631](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/631/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/125#issuecomment-23303331