[GitHub] [james-project] chibenwa commented on a change in pull request #504: JAMES-3516 Add threadId column to cassandra tables

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r656971819



##########
File path: mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdDAO.java
##########
@@ -352,6 +357,7 @@ private PreparedStatement prepareSelectUidRangeLimited(Session session) {
                         MessageUid.of(row.getLong(IMAP_UID))))
                 .flags(FlagsExtractor.getFlags(row))
                 .modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
+                .threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))

Review comment:
       Please handle the null case to allow a smooth upgrade




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org