You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "ethan256 (via GitHub)" <gi...@apache.org> on 2023/02/16 05:53:14 UTC
[GitHub] [skywalking] ethan256 opened a new issue, #10397: [Feature] Try to pull a docker image when the local image does not exist
ethan256 opened a new issue, #10397:
URL: https://github.com/apache/skywalking/issues/10397
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In the e2e test, can the e2e tool try to get the image when the docker image does not exist locally?
### Use case
setup:
env: kind
file: kind.yaml
kind:
pull-images:
- private-docker-images
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432645872
OK. That means you pre-configured the secret on the CI machine and don't want to put it in the e2e files, make sense to me. Welcome to contribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432642604
Could secret be set through system env?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ethan256 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "ethan256 (via GitHub)" <gi...@apache.org>.
ethan256 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432616448
> Are you going to contribute this to the project on your own? I think this feature is acceptable
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ethan256 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "ethan256 (via GitHub)" <gi...@apache.org>.
ethan256 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432616153
> Can you elaborate? I think this is the default behavior for Docker, when you use a Docker image, for example, use `docker run` or in docker compose, if the image doesn't exist locally it will try to pull from the docker hub
When I start in kind mode with skywalking-infra-e2e, the later import-images fail if a docker image for a private repository does not exist locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 closed issue #10397: [Feature] Try to pull a docker image when the local image does not exist
URL: https://github.com/apache/skywalking/issues/10397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432572878
Are you going to contribute this to the project on your own? I think this feature is acceptable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432583242
Can you elaborate? I think this is the default behavior for Docker, when you use a Docker image, for example, use `docker run` or in docker compose, if the image doesn't exit locally it will try to pull from the docker hub
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432631531
> > Can you elaborate? I think this is the default behavior for Docker, when you use a Docker image, for example, use `docker run` or in docker compose, if the image doesn't exist locally it will try to pull from the docker hub
>
>
>
> When I start in kind mode with skywalking-infra-e2e, the later import-images fail if a docker image for a private repository does not exist locally.
>
>
>
> In particular, in our CI scenario, we need to get the image from the private repository locally via docker pull on the CI machine in advance
Why not just add a docker pull secret and remove the load-images part in the e2e configuration file ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ethan256 commented on issue #10397: [Feature] Try to pull a docker image when the local image does not exist
Posted by "ethan256 (via GitHub)" <gi...@apache.org>.
ethan256 commented on issue #10397:
URL: https://github.com/apache/skywalking/issues/10397#issuecomment-1432640386
>
This will expose the secret
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org