You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2023/10/16 23:11:44 UTC

[PR] [SYSTEMDS-3631] Fix Integer casting bug in as.frame [systemds]

Baunsgaard opened a new pull request, #1923:
URL: https://github.com/apache/systemds/pull/1923

   This commit fixes the bug by solidify the isType detection to not allow casting to int on integers above Integer.MAX_VALUE and not cast to long on above Long.MAX_VALUE.
   
   Also added is a few tests to verify the behavior in some edge cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3631] Fix Integer casting bug in as.frame [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #1923:
URL: https://github.com/apache/systemds/pull/1923#issuecomment-1765410981

   Looks good to me and thanks for adding the test such that these issues don't happen again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3631] Fix Integer casting bug in as.frame [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #1923:
URL: https://github.com/apache/systemds/pull/1923#issuecomment-1765411300

   Feel free to merge it in yourself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [SYSTEMDS-3631] Fix Integer casting bug in as.frame [systemds]

Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #1923: [SYSTEMDS-3631] Fix Integer casting bug in as.frame
URL: https://github.com/apache/systemds/pull/1923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org