You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Kurt Deschler (Code Review)" <ge...@cloudera.org> on 2022/07/03 03:40:02 UTC

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Kurt Deschler has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18693


Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................

KUDU-2671 show custom hash schema in formatRangePartition

This patch adds printing of custom hash schema to formatRangePartition.
Hash schema information is appended to each range partition that has
custom hash partitions. Hash schema is not printed for ranges that use
the table-level hash schema, consistent with output prior to this change.

Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
1 file changed, 21 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/18693/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................

KUDU-2671 show custom hash schema in formatRangePartition

This patch introduces a new method targeted for Impala for formatted
output of table's range partitions along with hash their schemas.
Hash schema information is appended to each range partition.

Several test scenarios in TestKuduTable are updated to provide coverage
for the functionality of the newly introduced method
KuduTable.getFormattedRangePartitionsWithHashSchema().

Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Reviewed-on: http://gerrit.cloudera.org:8080/18693
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Kurt Deschler <kd...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
3 files changed, 76 insertions(+), 19 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified
  Kurt Deschler: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 4
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 21:39:45 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18693/2//COMMIT_MSG
Commit Message:

PS2: 
> It would be great to make this updated method/function used in the Kudu cod
OK: we can add more tests in a follow-up patch.  Impala is going to have some test coverage for this, anyways.



-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 21:21:38 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jul 2022 01:02:32 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 3: Verified+1

unrelated test and build failures


-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jul 2022 00:42:01 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 2:

(1 comment)

Thank you for the patch!

http://gerrit.cloudera.org:8080/#/c/18693/2//COMMIT_MSG
Commit Message:

PS2: 
It would be great to make this updated method/function used in the Kudu codebase (at least to catch future regressions, if any).

TestKuduTable.java seems to be a proper place to add those.  I guess we want to check for at least the following:
  * output for a range partition with hash schema with single dimension (with sub-cases of single and multiple columns to hash)
  * output for a range partition with hash schema with multiple hash dimensions (with sub-cases of single and multiple columns to hash)



-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jul 2022 15:59:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jul 2022 01:05:56 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Patch Set 2: -Code-Review

OK, I'll update the code to accommodate for the updated output of the new code.


-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jul 2022 21:49:34 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Kurt Deschler. ( http://gerrit.cloudera.org:8080/18693 )

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................

KUDU-2671 show custom hash schema in formatRangePartition

This patch introduces a new method targeted for Impala for formatted
output of table's range partitions along with hash their schemas.
Hash schema information is appended to each range partition.

Several test scenarios in TestKuduTable are updated to provide coverage
for the functionality of the newly introduced method
KuduTable.getFormattedRangePartitionsWithHashSchema().

Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Partition.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
3 files changed, 76 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/18693/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2671 show custom hash schema in formatRangePartition

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-2671 show custom hash schema in formatRangePartition
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia1a014ad820b2d73ea09fe3f67baefe9d0acb7aa
Gerrit-Change-Number: 18693
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>