You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ambud <gi...@git.apache.org> on 2016/12/01 20:25:18 UTC
[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...
GitHub user ambud opened a pull request:
https://github.com/apache/storm/pull/1810
STORM-2204 Adding Bolt side caching for HBase Lookup Bolt for 1.x branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ambud/storm 1.x-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1810.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1810
----
commit d4f996d9a17289b9c08a500c327e469b69384aeb
Author: ambud <am...@192.168.56.1>
Date: 2016-12-01T20:22:42Z
Bolt side caching for HBase Lookup Bolt for 1.x branch
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1810
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1810#discussion_r92120117
--- Diff: external/storm-hbase/pom.xml ---
@@ -87,5 +87,9 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
--- End diff --
same as above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1810
@ambud Code looks good, but indentation is really off. Could you take care of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1810
@ambud
The last change looks good. Please squash the commits into one. I'll merge after rebasing.
If you mind squashing I'd be happy to do it instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1810#discussion_r92120044
--- Diff: external/storm-hbase/pom.xml ---
@@ -87,5 +87,9 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
--- End diff --
Please use white space instead of tab space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on the issue:
https://github.com/apache/storm/pull/1810
https://github.com/apache/storm/pull/1783 original PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on the issue:
https://github.com/apache/storm/pull/1810
@HeartSaVioR i fixed the issues; build failed because what seems to be a transient failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1810
Master branch of storm-hbase still has guava as dependency even we use Caffeine, since hbase-server depends on Guava 16.0.1.
So this patch doesn't add new guava dependency. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on the issue:
https://github.com/apache/storm/pull/1810
@HeartSaVioR done, please let me know if any other changes need to be made. Looks like the space indentation is off my a little, please let me know if that will be an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1810#discussion_r90638449
--- Diff: external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java ---
@@ -56,6 +66,30 @@ public HBaseLookupBolt withConfigKey(String configKey){
this.configKey = configKey;
return this;
}
+
+ @SuppressWarnings({ "unchecked", "rawtypes" })
+ @Override
+ public void prepare(Map map, TopologyContext topologyContext, OutputCollector collector) {
+ super.prepare(map, topologyContext, collector);
+ cacheEnabled = Boolean.parseBoolean(map.getOrDefault("hbase.cache.enable", "false").toString());
--- End diff --
@ambud
As I said from #1783 getOrDefault() is not compiled with JDK7. Please build with JDK7 before submitting pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1810
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1810
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on the issue:
https://github.com/apache/storm/pull/1810
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---