[jira] [Commented] (JCRVLT-509) Make authorizable and access control installation failure make the whole installation fail

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298106#comment-17298106 ] 

Konrad Windszus commented on JCRVLT-509:
----------------------------------------

[~tripod] Do you remember why you treat those installation exceptions differently from e.g. regular node installation exceptions?

> Make authorizable and access control installation failure make the whole installation fail
> ------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-509
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-509
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>    Affects Versions: 3.4.10
>            Reporter: Konrad Windszus
>            Priority: Major
>             Fix For: 3.4.12
>
>
> Currently all ACL and authorizable exceptions are caught in https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/impl/io/DocViewSAXImporter.java#L683 and just logged. Afterwards the import of the package just continues.
> As I consider a failure to install ACLs/authorizable fatal (i.e. non-recoverable) it should lead to a PackageException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)