You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "W-M-R (via GitHub)" <gi...@apache.org> on 2024/11/06 09:23:40 UTC

[PR] libxx: All cxx libraries move down one level [nuttx]

W-M-R opened a new pull request, #14668:
URL: https://github.com/apache/nuttx/pull/14668

   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   libxx: All cxx libraries move down one level
   ## Impact
   No
   ## Testing
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.

lupyuen commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2461410149

   Sorry I have to cancel the CI Check, there's a problem with CI Test:
   - https://github.com/apache/nuttx/pull/14667#issuecomment-2461197521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.

lupyuen commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2462063147

   Sorry I cancelled the CI Check again, since there's a problem with CI Test:
   - https://github.com/apache/nuttx/pull/14667#issuecomment-2461197521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.

xiaoxiang781216 commented on code in PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#discussion_r1831417282


##########
libs/libxx/uClibc++/CMakeLists.txt:
##########
@@ -0,0 +1,116 @@
+# ##############################################################################
+# libs/libxx/uClibc++.cmake

Review Comment:
   please update ALL files



##########
libs/libxx/uClibc++/CMakeLists.txt:
##########
@@ -0,0 +1,116 @@
+# ##############################################################################
+# libs/libxx/uClibc++.cmake

Review Comment:
   @W-M-R please update ALL files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.

lupyuen commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2461450672

   @W-M-R Hopefully not? Let us track down the root cause and figure out the impact. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.

xiaoxiang781216 merged PR #14668:
URL: https://github.com/apache/nuttx/pull/14668


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.

xiaoxiang781216 commented on code in PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#discussion_r1831413954


##########
libs/libxx/uClibc++/Make.defs:
##########
@@ -23,27 +23,29 @@
 UCLIBCXX_VERSION=0.2.5
 
 # Download and unpack tarball if no git repo found
-ifeq ($(wildcard uClibc++/.git),)

Review Comment:
   change line 1 to:
   ```
   libs/libxx/uClibc++/Make.defs
   ```



##########
libs/libxx/uClibc++/CMakeLists.txt:
##########
@@ -0,0 +1,116 @@
+# ##############################################################################
+# libs/libxx/uClibc++.cmake

Review Comment:
   ```suggestion
   # llibs/libxx/uClibc++/CMakeLists.txt
   
   ```



##########
libs/libxx/libcxx/CMakeLists.txt:
##########
@@ -0,0 +1,127 @@
+# ##############################################################################
+# libs/libxx/libcxx.cmake

Review Comment:
   ```suggestion
   # libs/libxx/libcxx/CMakeLists.txt
   ```



##########
libs/libxx/libcxxabi/CMakeLists.txt:
##########
@@ -0,0 +1,125 @@
+# ##############################################################################
+# libs/libxx/libcxxabi.cmake

Review Comment:
   ```suggestion
   # libs/libxx/libcxxabi/CMakeLists.txt
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.

nuttxpr commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2459114071

[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)

No. This PR does not adequately meet the NuttX requirements. While it provides a brief summary, it lacks crucial details. Here's why:

* **Insufficient Summary:** "All cxx libraries move down one level" is vague. *Why* was this move necessary? What problem does it solve? What specific libraries are affected? What does "down one level" mean in terms of directory structure?
* **Missing Issue References:** Are there related NuttX or NuttX Apps issues that prompted this change? These should be linked.
* **Impact Underexplored:** Simply stating "No" for all impact categories is insufficient. Even seemingly simple changes can have unforeseen consequences. Consider build processes, dependencies, and potential compatibility issues. Justify *why* there's no impact in each area. For example, if there's no impact on the build, explain why moving the libraries doesn't affect build scripts or dependencies.
* **Inadequate Testing:** Stating "depends on another PR" isn't enough. While dependencies exist, this PR needs its *own* verification. Provide specific build host and target details, along with "before" and "after" logs demonstrating the change's effectiveness and the lack of unintended side effects. What happens if the other PR isn't merged? How is this PR tested independently?

**In short, the PR needs to be significantly more detailed and self-contained to meet the NuttX requirements.** It should clearly explain the motivation, implementation details, potential impact, and provide independent verification of its functionality.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.

W-M-R commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2459697574

   > Approved, but please include an explanatory message in the commit log as to why this was necessary?
   
   OKey


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] libxx: All cxx libraries move down one level [nuttx]

Posted by "W-M-R (via GitHub)" <gi...@apache.org>.

W-M-R commented on PR #14668:
URL: https://github.com/apache/nuttx/pull/14668#issuecomment-2461448188

   > Sorry I have to cancel the CI Check, there's a problem with CI Test:
   > 
   > * [drivers/pipes: return after short write if buffer is full #14667 (comment)](https://github.com/apache/nuttx/pull/14667#issuecomment-2461197521)
   
   Do we need to restart ci after the fix is merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org