You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/07/13 17:21:08 UTC
[GitHub] [accumulo] cshannon opened a new issue, #2807: Update Accumulo utilities to extend KeywordExecutable
cshannon opened a new issue, #2807:
URL: https://github.com/apache/accumulo/issues/2807
Must utility applications extend [KeywordExecutable](https://github.com/apache/accumulo/blob/main/start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java). However, there are some that don't and these should be updated to do so. These applications are meant to be used with the `accumulo` command.
I did a search and some examples that could be updated as part of this issue:
- [DumpZookeeper](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/DumpZookeeper.java)
- [LocalityCheck](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/LocalityCheck.java)
- [ChangeSecret](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/ChangeSecret.java)
- [DeleteZooInstance](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/DeleteZooInstance.java)
- [FindOfflineTablets](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/FindOfflineTablets.java)
- [RestoreZookeeper](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/RestoreZookeeper.java)
- [TableDiskUsage](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java)
- [TabletServerLocks](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/TabletServerLocks.java)
- [VerifyTabletAssignments](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/VerifyTabletAssignments.java)
I will create PRs for these and submit them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
milleruntime commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1187528970
Where you able to test each of these utilities? Some may be in an unknown working condition. Adding the Keywords to the commands will make them show up under the main `accumulo` command, making them more visible to the user. I think this is good for some, `DumpZookeeper` and `TableDiskUsage` for example, are more general purpose utilities. Other commands such as `ChangeSecret` and the Delete and Restore ZK, might be better served under the `Admin` command since these should only be used on a rare occasion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1189031683
@milleruntime - I just went through and rebased all the PRs off the latest off main and fixed the descriptions and commit messages for them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1183614377
I submitted PRs for a couple of these so far, I will continue with more this weekend. Not sure if there are any existing tests that need to be updated besides the one keyword I test but I can do a search as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1186221447
@dlmarion and @EdColeman - Ok this is ready for review, I went ahead and tackled 8 utilities for now, each with their own PR to review in isolation. I verified everything works using Uno and the accumulo command for each utility.
For the [UsageGroup](https://github.com/apache/accumulo/blob/main/start/src/main/java/org/apache/accumulo/start/spi/KeywordExecutable.java#L46) all the commands are just added under the default `OTHER` but this can be changed easily. Also some of these may be a candidate to be encapsulated under the [Admin](https://github.com/apache/accumulo/blob/main/server/base/src/main/java/org/apache/accumulo/server/util/Admin.java) command but for now I just made them their own commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1187911027
@milleruntime - I updated the PRs for DeleteZooInstance, RestoreZooInstance and ChangeSecret to now be included as part of the `admin` command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime closed issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
milleruntime closed issue #2807: Update Accumulo utilities to extend KeywordExecutable
URL: https://github.com/apache/accumulo/issues/2807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2807: Update Accumulo utilities to extend KeywordExecutable
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2807:
URL: https://github.com/apache/accumulo/issues/2807#issuecomment-1187567084
@milleruntime -
1. Testing - I ran all the commands against Uno and they _seemed_ to work but since I'm pretty new I wasn't sure how to verify the output on all of them. I looked around and didn't really see any existing unit tests for the utilities themselves to verify they work or functionality. Maybe another task should be to actually write some unit tests for these commands to verify they work (using mini accumulo, etc). I could create a new issue and PRs to add tests (if you agree they should be a separate issue)
2. I agree that I figured some of them would make more sense as part of the Admin command as I mentioned but wasn't sure which ones. I worked on 8 so far, I can updated my PRs and move ChangeSecret, Delete and Restore ZK to the Admin command. Any others you think?
3. I am also going to search around the code now and take a look now to see if there's anymore commands to fix but if you know of any others let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org