You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ar...@apache.org on 2016/09/17 10:10:15 UTC

svn commit: r1761175 - in /ofbiz/trunk: applications/humanres/ applications/humanres/servicedef/ applications/product/ applications/product/servicedef/ framework/entity/ framework/entity/servicedef/

Author: arunpatidar
Date: Sat Sep 17 10:10:15 2016
New Revision: 1761175

URL: http://svn.apache.org/viewvc?rev=1761175&view=rev
Log:
Implemented: Added CRUD services for EmplPositionClassType, ConfigOptionProductOption and Component entity.
(OFBIZ-8049) (OFBIZ-8058)(OFBIZ-8059)

Thanks: Amit Gadaley for the contribution.

Added:
    ofbiz/trunk/applications/humanres/servicedef/services_position.xml
    ofbiz/trunk/applications/product/servicedef/services_config.xml
    ofbiz/trunk/framework/entity/servicedef/
    ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
Modified:
    ofbiz/trunk/applications/humanres/ofbiz-component.xml
    ofbiz/trunk/applications/product/ofbiz-component.xml
    ofbiz/trunk/framework/entity/ofbiz-component.xml

Modified: ofbiz/trunk/applications/humanres/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
==============================================================================
--- ofbiz/trunk/applications/humanres/ofbiz-component.xml (original)
+++ ofbiz/trunk/applications/humanres/ofbiz-component.xml Sat Sep 17 10:10:15 2016
@@ -33,6 +33,7 @@ under the License.
     <entity-resource type="data" reader-name="demo" loader="main" location="data/HumanResDemoData.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_employment.xml"/>
+    <service-resource type="model" loader="main" location="servicedef/services_position.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_upgrade.xml"/>
 
     <webapp name="humanres"

Added: ofbiz/trunk/applications/humanres/servicedef/services_position.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services_position.xml?rev=1761175&view=auto
==============================================================================
--- ofbiz/trunk/applications/humanres/servicedef/services_position.xml (added)
+++ ofbiz/trunk/applications/humanres/servicedef/services_position.xml Sat Sep 17 10:10:15 2016
@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/services.xsd">
+    <description>Humanres Services</description>
+    <vendor>OFBiz</vendor>
+
+    <service name="createEmplPositionClassType" default-entity-name="EmplPositionClassType" engine="entity-auto" invoke="create" auth="true">
+        <description>Create a EmplPositionClassType record</description>
+        <auto-attributes mode="INOUT" include="pk" optional="true"/>
+        <auto-attributes mode="IN" include="nonpk" optional="true"/>
+    </service>
+    <service name="updateEmplPositionClassType" default-entity-name="EmplPositionClassType" engine="entity-auto" invoke="update" auth="true">
+        <description>Update a record</description>
+        <auto-attributes mode="IN" include="pk"/>
+        <auto-attributes mode="IN" include="nonpk" optional="true"/>
+    </service>
+    <service name="deleteEmplPositionClassType" default-entity-name="EmplPositionClassType" engine="entity-auto" invoke="delete" auth="true">
+        <description>Delete a record</description>
+        <auto-attributes mode="IN" include="pk"/>
+    </service>
+</services>

Modified: ofbiz/trunk/applications/product/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/ofbiz-component.xml (original)
+++ ofbiz/trunk/applications/product/ofbiz-component.xml Sat Sep 17 10:10:15 2016
@@ -59,6 +59,7 @@ under the License.
     <service-resource type="model" loader="main" location="servicedef/services_subscription.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_rental.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_view.xml"/>
+    <service-resource type="model" loader="main" location="servicedef/services_config.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_cost.xml"/>
     <service-resource type="model" loader="main" location="servicedef/services_uom.xml"/>
     <service-resource type="eca" loader="main" location="servicedef/secas.xml"/>

Added: ofbiz/trunk/applications/product/servicedef/services_config.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services_config.xml?rev=1761175&view=auto
==============================================================================
--- ofbiz/trunk/applications/product/servicedef/services_config.xml (added)
+++ ofbiz/trunk/applications/product/servicedef/services_config.xml Sat Sep 17 10:10:15 2016
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/services.xsd">
+    <description>Product Config Services</description>
+    <vendor>OFBiz</vendor>
+    <version>1.0</version>
+
+    <service name="createConfigOptionProductOption" default-entity-name="ConfigOptionProductOption" engine="entity-auto" invoke="create" auth="true">
+        <description>Create a new ConfigOptionProductOption Record</description>
+        <auto-attributes mode="IN" include="pk"/>
+        <auto-attributes mode="IN" include="nonpk" optional="true"/>
+    </service>
+    <service name="updateConfigOptionProductOption" default-entity-name="ConfigOptionProductOption" engine="entity-auto" invoke="update" auth="true">
+        <description>Update a ConfigOptionProductOption record</description>
+        <auto-attributes include="pk" mode="IN"/>
+        <auto-attributes include="nonpk" mode="IN" optional="true"/>
+    </service>
+    <service name="deleteConfigOptionProductOption" default-entity-name="ConfigOptionProductOption" engine="entity-auto" invoke="delete" auth="true">
+        <description>Delete an existing ConfigOptionProductOption Record</description>
+        <auto-attributes mode="IN" include="pk"/>
+    </service>
+</services>

Modified: ofbiz/trunk/framework/entity/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/ofbiz-component.xml (original)
+++ ofbiz/trunk/framework/entity/ofbiz-component.xml Sat Sep 17 10:10:15 2016
@@ -28,6 +28,8 @@ under the License.
     <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel.xml"/>
     <entity-resource type="group" reader-name="main" loader="main" location="entitydef/entitygroup.xml"/>
     
+    <service-resource type="model" loader="main" location="servicedef/services_tenant.xml"/>
+    
     <!-- these are for unit testing -->
     <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel_test.xml"/>
     

Added: ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/servicedef/services_tenant.xml?rev=1761175&view=auto
==============================================================================
--- ofbiz/trunk/framework/entity/servicedef/services_tenant.xml (added)
+++ ofbiz/trunk/framework/entity/servicedef/services_tenant.xml Sat Sep 17 10:10:15 2016
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/services.xsd">
+    <description>Entity Tenant Services</description>
+    <vendor>OFBiz</vendor>
+    <version>1.0</version>
+
+    <service name="createComponent" default-entity-name="Component" engine="entity-auto" invoke="create" auth="true">
+        <description>Create a new Component Record</description>
+        <auto-attributes mode="IN" include="pk"/>
+        <auto-attributes mode="IN" include="nonpk" optional="true"/>
+    </service>
+    <service name="updateComponent" default-entity-name="Component" engine="entity-auto" invoke="update" auth="true">
+        <description>Update a Component record</description>
+        <auto-attributes include="pk" mode="IN"/>
+        <auto-attributes include="nonpk" mode="IN" optional="true"/>
+    </service>
+    <service name="deleteComponent" default-entity-name="Component" engine="entity-auto" invoke="delete" auth="true">
+        <description>Delete a Component record</description>
+        <auto-attributes include="pk" mode="IN"/>
+        <auto-attributes include="nonpk" mode="IN" optional="true"/>
+    </service>
+</services>



Re: svn commit: r1761175 - in /ofbiz/trunk: applications/humanres/ applications/humanres/servicedef/ applications/product/ applications/product/servicedef/ framework/entity/ framework/entity/servicedef/

Posted by Arun Patidar <ar...@hotwaxsystems.com>.
Thanks Jacopo, I am looking into this.

-- 
Thanks & Regards
---
Arun Patidar
Manager,Enterprise Software Development
HotWax Mediawww.hotwaxsystems.com


On Tue, Sep 20, 2016 at 11:07 AM, Jacopo Cappellato <
jacopo.cappellato@hotwaxsystems.com> wrote:

> Hi Arun,
>
> your commit is causing an XML parsing error at startup for the file
> enity/ofbiz-component.xml.
> The problem is that service-resource should come after all the
> entity-resource element.
> Could you please fix this? Thanks.
>
> Additionally, I don't like the idea of introducing a dependency from the
> entity component to the service component; while I know this is not the
> only one, ideally the entity component should be at a lower level than the
> service component or they should stay (in an even more idealistic World :-)
> ) at the same level (i.e. with no dependency between them, with all
> dependencies moved into a new component that provides features integrating
> entity and service functionalities).
> In short, I am proposing to move these new CRUD services from the entity to
> the entityext component.
>
> Kind regards,
>
> Jacopo
>
>
> On Sat, Sep 17, 2016 at 12:10 PM, <ar...@apache.org> wrote:
>
> > Author: arunpatidar
> > Date: Sat Sep 17 10:10:15 2016
> > New Revision: 1761175
> >
> > URL: http://svn.apache.org/viewvc?rev=1761175&view=rev
> > Log:
> > Implemented: Added CRUD services for EmplPositionClassType,
> > ConfigOptionProductOption and Component entity.
> > (OFBIZ-8049) (OFBIZ-8058)(OFBIZ-8059)
> >
> > Thanks: Amit Gadaley for the contribution.
> >
> > Added:
> >     ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> >     ofbiz/trunk/applications/product/servicedef/services_config.xml
> >     ofbiz/trunk/framework/entity/servicedef/
> >     ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
> > Modified:
> >     ofbiz/trunk/applications/humanres/ofbiz-component.xml
> >     ofbiz/trunk/applications/product/ofbiz-component.xml
> >     ofbiz/trunk/framework/entity/ofbiz-component.xml
> >
> > Modified: ofbiz/trunk/applications/humanres/ofbiz-component.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > humanres/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> > ============================================================
> > ==================
> > --- ofbiz/trunk/applications/humanres/ofbiz-component.xml (original)
> > +++ ofbiz/trunk/applications/humanres/ofbiz-component.xml Sat Sep 17
> > 10:10:15 2016
> > @@ -33,6 +33,7 @@ under the License.
> >      <entity-resource type="data" reader-name="demo" loader="main"
> > location="data/HumanResDemoData.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_employment.xml"/>
> > +    <service-resource type="model" loader="main"
> > location="servicedef/services_position.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_upgrade.xml"/>
> >
> >      <webapp name="humanres"
> >
> > Added: ofbiz/trunk/applications/humanres/servicedef/services_
> position.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > humanres/servicedef/services_position.xml?rev=1761175&view=auto
> > ============================================================
> > ==================
> > --- ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> > (added)
> > +++ ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> > Sat Sep 17 10:10:15 2016
> > @@ -0,0 +1,40 @@
> > +<?xml version="1.0" encoding="UTF-8"?>
> > +<!--
> > +Licensed to the Apache Software Foundation (ASF) under one
> > +or more contributor license agreements.  See the NOTICE file
> > +distributed with this work for additional information
> > +regarding copyright ownership.  The ASF licenses this file
> > +to you under the Apache License, Version 2.0 (the
> > +"License"); you may not use this file except in compliance
> > +with the License.  You may obtain a copy of the License at
> > +
> > +http://www.apache.org/licenses/LICENSE-2.0
> > +
> > +Unless required by applicable law or agreed to in writing,
> > +software distributed under the License is distributed on an
> > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > +KIND, either express or implied.  See the License for the
> > +specific language governing permissions and limitations
> > +under the License.
> > +-->
> > +
> > +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> > +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> > services.xsd">
> > +    <description>Humanres Services</description>
> > +    <vendor>OFBiz</vendor>
> > +
> > +    <service name="createEmplPositionClassType" default-entity-name="
> EmplPositionClassType"
> > engine="entity-auto" invoke="create" auth="true">
> > +        <description>Create a EmplPositionClassType record</description>
> > +        <auto-attributes mode="INOUT" include="pk" optional="true"/>
> > +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> > +    </service>
> > +    <service name="updateEmplPositionClassType" default-entity-name="
> EmplPositionClassType"
> > engine="entity-auto" invoke="update" auth="true">
> > +        <description>Update a record</description>
> > +        <auto-attributes mode="IN" include="pk"/>
> > +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> > +    </service>
> > +    <service name="deleteEmplPositionClassType" default-entity-name="
> EmplPositionClassType"
> > engine="entity-auto" invoke="delete" auth="true">
> > +        <description>Delete a record</description>
> > +        <auto-attributes mode="IN" include="pk"/>
> > +    </service>
> > +</services>
> >
> > Modified: ofbiz/trunk/applications/product/ofbiz-component.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > product/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> > ============================================================
> > ==================
> > --- ofbiz/trunk/applications/product/ofbiz-component.xml (original)
> > +++ ofbiz/trunk/applications/product/ofbiz-component.xml Sat Sep 17
> > 10:10:15 2016
> > @@ -59,6 +59,7 @@ under the License.
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_subscription.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_rental.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_view.xml"/>
> > +    <service-resource type="model" loader="main"
> > location="servicedef/services_config.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_cost.xml"/>
> >      <service-resource type="model" loader="main"
> > location="servicedef/services_uom.xml"/>
> >      <service-resource type="eca" loader="main"
> location="servicedef/secas.
> > xml"/>
> >
> > Added: ofbiz/trunk/applications/product/servicedef/services_config.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> > product/servicedef/services_config.xml?rev=1761175&view=auto
> > ============================================================
> > ==================
> > --- ofbiz/trunk/applications/product/servicedef/services_config.xml
> > (added)
> > +++ ofbiz/trunk/applications/product/servicedef/services_config.xml Sat
> > Sep 17 10:10:15 2016
> > @@ -0,0 +1,41 @@
> > +<?xml version="1.0" encoding="UTF-8"?>
> > +<!--
> > +Licensed to the Apache Software Foundation (ASF) under one
> > +or more contributor license agreements.  See the NOTICE file
> > +distributed with this work for additional information
> > +regarding copyright ownership.  The ASF licenses this file
> > +to you under the Apache License, Version 2.0 (the
> > +"License"); you may not use this file except in compliance
> > +with the License.  You may obtain a copy of the License at
> > +
> > +http://www.apache.org/licenses/LICENSE-2.0
> > +
> > +Unless required by applicable law or agreed to in writing,
> > +software distributed under the License is distributed on an
> > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > +KIND, either express or implied.  See the License for the
> > +specific language governing permissions and limitations
> > +under the License.
> > +-->
> > +
> > +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> > +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> > services.xsd">
> > +    <description>Product Config Services</description>
> > +    <vendor>OFBiz</vendor>
> > +    <version>1.0</version>
> > +
> > +    <service name="createConfigOptionProductOption"
> default-entity-name="ConfigOptionProductOption"
> > engine="entity-auto" invoke="create" auth="true">
> > +        <description>Create a new ConfigOptionProductOption
> > Record</description>
> > +        <auto-attributes mode="IN" include="pk"/>
> > +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> > +    </service>
> > +    <service name="updateConfigOptionProductOption"
> default-entity-name="ConfigOptionProductOption"
> > engine="entity-auto" invoke="update" auth="true">
> > +        <description>Update a ConfigOptionProductOption
> > record</description>
> > +        <auto-attributes include="pk" mode="IN"/>
> > +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> > +    </service>
> > +    <service name="deleteConfigOptionProductOption"
> default-entity-name="ConfigOptionProductOption"
> > engine="entity-auto" invoke="delete" auth="true">
> > +        <description>Delete an existing ConfigOptionProductOption
> > Record</description>
> > +        <auto-attributes mode="IN" include="pk"/>
> > +    </service>
> > +</services>
> >
> > Modified: ofbiz/trunk/framework/entity/ofbiz-component.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/
> > ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> > ============================================================
> > ==================
> > --- ofbiz/trunk/framework/entity/ofbiz-component.xml (original)
> > +++ ofbiz/trunk/framework/entity/ofbiz-component.xml Sat Sep 17 10:10:15
> > 2016
> > @@ -28,6 +28,8 @@ under the License.
> >      <entity-resource type="model" reader-name="main" loader="main"
> > location="entitydef/entitymodel.xml"/>
> >      <entity-resource type="group" reader-name="main" loader="main"
> > location="entitydef/entitygroup.xml"/>
> >
> > +    <service-resource type="model" loader="main"
> > location="servicedef/services_tenant.xml"/>
> > +
> >      <!-- these are for unit testing -->
> >      <entity-resource type="model" reader-name="main" loader="main"
> > location="entitydef/entitymodel_test.xml"/>
> >
> >
> > Added: ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/
> > servicedef/services_tenant.xml?rev=1761175&view=auto
> > ============================================================
> > ==================
> > --- ofbiz/trunk/framework/entity/servicedef/services_tenant.xml (added)
> > +++ ofbiz/trunk/framework/entity/servicedef/services_tenant.xml Sat Sep
> > 17 10:10:15 2016
> > @@ -0,0 +1,42 @@
> > +<?xml version="1.0" encoding="UTF-8"?>
> > +<!--
> > +Licensed to the Apache Software Foundation (ASF) under one
> > +or more contributor license agreements.  See the NOTICE file
> > +distributed with this work for additional information
> > +regarding copyright ownership.  The ASF licenses this file
> > +to you under the Apache License, Version 2.0 (the
> > +"License"); you may not use this file except in compliance
> > +with the License.  You may obtain a copy of the License at
> > +
> > +http://www.apache.org/licenses/LICENSE-2.0
> > +
> > +Unless required by applicable law or agreed to in writing,
> > +software distributed under the License is distributed on an
> > +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > +KIND, either express or implied.  See the License for the
> > +specific language governing permissions and limitations
> > +under the License.
> > +-->
> > +
> > +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> > +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> > services.xsd">
> > +    <description>Entity Tenant Services</description>
> > +    <vendor>OFBiz</vendor>
> > +    <version>1.0</version>
> > +
> > +    <service name="createComponent" default-entity-name="Component"
> > engine="entity-auto" invoke="create" auth="true">
> > +        <description>Create a new Component Record</description>
> > +        <auto-attributes mode="IN" include="pk"/>
> > +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> > +    </service>
> > +    <service name="updateComponent" default-entity-name="Component"
> > engine="entity-auto" invoke="update" auth="true">
> > +        <description>Update a Component record</description>
> > +        <auto-attributes include="pk" mode="IN"/>
> > +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> > +    </service>
> > +    <service name="deleteComponent" default-entity-name="Component"
> > engine="entity-auto" invoke="delete" auth="true">
> > +        <description>Delete a Component record</description>
> > +        <auto-attributes include="pk" mode="IN"/>
> > +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> > +    </service>
> > +</services>
> >
> >
> >
>

Re: svn commit: r1761175 - in /ofbiz/trunk: applications/humanres/ applications/humanres/servicedef/ applications/product/ applications/product/servicedef/ framework/entity/ framework/entity/servicedef/

Posted by Jacopo Cappellato <ja...@hotwaxsystems.com>.
Hi Arun,

your commit is causing an XML parsing error at startup for the file
enity/ofbiz-component.xml.
The problem is that service-resource should come after all the
entity-resource element.
Could you please fix this? Thanks.

Additionally, I don't like the idea of introducing a dependency from the
entity component to the service component; while I know this is not the
only one, ideally the entity component should be at a lower level than the
service component or they should stay (in an even more idealistic World :-)
) at the same level (i.e. with no dependency between them, with all
dependencies moved into a new component that provides features integrating
entity and service functionalities).
In short, I am proposing to move these new CRUD services from the entity to
the entityext component.

Kind regards,

Jacopo


On Sat, Sep 17, 2016 at 12:10 PM, <ar...@apache.org> wrote:

> Author: arunpatidar
> Date: Sat Sep 17 10:10:15 2016
> New Revision: 1761175
>
> URL: http://svn.apache.org/viewvc?rev=1761175&view=rev
> Log:
> Implemented: Added CRUD services for EmplPositionClassType,
> ConfigOptionProductOption and Component entity.
> (OFBIZ-8049) (OFBIZ-8058)(OFBIZ-8059)
>
> Thanks: Amit Gadaley for the contribution.
>
> Added:
>     ofbiz/trunk/applications/humanres/servicedef/services_position.xml
>     ofbiz/trunk/applications/product/servicedef/services_config.xml
>     ofbiz/trunk/framework/entity/servicedef/
>     ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
> Modified:
>     ofbiz/trunk/applications/humanres/ofbiz-component.xml
>     ofbiz/trunk/applications/product/ofbiz-component.xml
>     ofbiz/trunk/framework/entity/ofbiz-component.xml
>
> Modified: ofbiz/trunk/applications/humanres/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> humanres/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> ============================================================
> ==================
> --- ofbiz/trunk/applications/humanres/ofbiz-component.xml (original)
> +++ ofbiz/trunk/applications/humanres/ofbiz-component.xml Sat Sep 17
> 10:10:15 2016
> @@ -33,6 +33,7 @@ under the License.
>      <entity-resource type="data" reader-name="demo" loader="main"
> location="data/HumanResDemoData.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_employment.xml"/>
> +    <service-resource type="model" loader="main"
> location="servicedef/services_position.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_upgrade.xml"/>
>
>      <webapp name="humanres"
>
> Added: ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> humanres/servicedef/services_position.xml?rev=1761175&view=auto
> ============================================================
> ==================
> --- ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> (added)
> +++ ofbiz/trunk/applications/humanres/servicedef/services_position.xml
> Sat Sep 17 10:10:15 2016
> @@ -0,0 +1,40 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +Licensed to the Apache Software Foundation (ASF) under one
> +or more contributor license agreements.  See the NOTICE file
> +distributed with this work for additional information
> +regarding copyright ownership.  The ASF licenses this file
> +to you under the Apache License, Version 2.0 (the
> +"License"); you may not use this file except in compliance
> +with the License.  You may obtain a copy of the License at
> +
> +http://www.apache.org/licenses/LICENSE-2.0
> +
> +Unless required by applicable law or agreed to in writing,
> +software distributed under the License is distributed on an
> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +KIND, either express or implied.  See the License for the
> +specific language governing permissions and limitations
> +under the License.
> +-->
> +
> +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> services.xsd">
> +    <description>Humanres Services</description>
> +    <vendor>OFBiz</vendor>
> +
> +    <service name="createEmplPositionClassType" default-entity-name="EmplPositionClassType"
> engine="entity-auto" invoke="create" auth="true">
> +        <description>Create a EmplPositionClassType record</description>
> +        <auto-attributes mode="INOUT" include="pk" optional="true"/>
> +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> +    </service>
> +    <service name="updateEmplPositionClassType" default-entity-name="EmplPositionClassType"
> engine="entity-auto" invoke="update" auth="true">
> +        <description>Update a record</description>
> +        <auto-attributes mode="IN" include="pk"/>
> +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> +    </service>
> +    <service name="deleteEmplPositionClassType" default-entity-name="EmplPositionClassType"
> engine="entity-auto" invoke="delete" auth="true">
> +        <description>Delete a record</description>
> +        <auto-attributes mode="IN" include="pk"/>
> +    </service>
> +</services>
>
> Modified: ofbiz/trunk/applications/product/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> product/ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> ============================================================
> ==================
> --- ofbiz/trunk/applications/product/ofbiz-component.xml (original)
> +++ ofbiz/trunk/applications/product/ofbiz-component.xml Sat Sep 17
> 10:10:15 2016
> @@ -59,6 +59,7 @@ under the License.
>      <service-resource type="model" loader="main"
> location="servicedef/services_subscription.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_rental.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_view.xml"/>
> +    <service-resource type="model" loader="main"
> location="servicedef/services_config.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_cost.xml"/>
>      <service-resource type="model" loader="main"
> location="servicedef/services_uom.xml"/>
>      <service-resource type="eca" loader="main" location="servicedef/secas.
> xml"/>
>
> Added: ofbiz/trunk/applications/product/servicedef/services_config.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/
> product/servicedef/services_config.xml?rev=1761175&view=auto
> ============================================================
> ==================
> --- ofbiz/trunk/applications/product/servicedef/services_config.xml
> (added)
> +++ ofbiz/trunk/applications/product/servicedef/services_config.xml Sat
> Sep 17 10:10:15 2016
> @@ -0,0 +1,41 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +Licensed to the Apache Software Foundation (ASF) under one
> +or more contributor license agreements.  See the NOTICE file
> +distributed with this work for additional information
> +regarding copyright ownership.  The ASF licenses this file
> +to you under the Apache License, Version 2.0 (the
> +"License"); you may not use this file except in compliance
> +with the License.  You may obtain a copy of the License at
> +
> +http://www.apache.org/licenses/LICENSE-2.0
> +
> +Unless required by applicable law or agreed to in writing,
> +software distributed under the License is distributed on an
> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +KIND, either express or implied.  See the License for the
> +specific language governing permissions and limitations
> +under the License.
> +-->
> +
> +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> services.xsd">
> +    <description>Product Config Services</description>
> +    <vendor>OFBiz</vendor>
> +    <version>1.0</version>
> +
> +    <service name="createConfigOptionProductOption" default-entity-name="ConfigOptionProductOption"
> engine="entity-auto" invoke="create" auth="true">
> +        <description>Create a new ConfigOptionProductOption
> Record</description>
> +        <auto-attributes mode="IN" include="pk"/>
> +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> +    </service>
> +    <service name="updateConfigOptionProductOption" default-entity-name="ConfigOptionProductOption"
> engine="entity-auto" invoke="update" auth="true">
> +        <description>Update a ConfigOptionProductOption
> record</description>
> +        <auto-attributes include="pk" mode="IN"/>
> +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> +    </service>
> +    <service name="deleteConfigOptionProductOption" default-entity-name="ConfigOptionProductOption"
> engine="entity-auto" invoke="delete" auth="true">
> +        <description>Delete an existing ConfigOptionProductOption
> Record</description>
> +        <auto-attributes mode="IN" include="pk"/>
> +    </service>
> +</services>
>
> Modified: ofbiz/trunk/framework/entity/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/
> ofbiz-component.xml?rev=1761175&r1=1761174&r2=1761175&view=diff
> ============================================================
> ==================
> --- ofbiz/trunk/framework/entity/ofbiz-component.xml (original)
> +++ ofbiz/trunk/framework/entity/ofbiz-component.xml Sat Sep 17 10:10:15
> 2016
> @@ -28,6 +28,8 @@ under the License.
>      <entity-resource type="model" reader-name="main" loader="main"
> location="entitydef/entitymodel.xml"/>
>      <entity-resource type="group" reader-name="main" loader="main"
> location="entitydef/entitygroup.xml"/>
>
> +    <service-resource type="model" loader="main"
> location="servicedef/services_tenant.xml"/>
> +
>      <!-- these are for unit testing -->
>      <entity-resource type="model" reader-name="main" loader="main"
> location="entitydef/entitymodel_test.xml"/>
>
>
> Added: ofbiz/trunk/framework/entity/servicedef/services_tenant.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/
> servicedef/services_tenant.xml?rev=1761175&view=auto
> ============================================================
> ==================
> --- ofbiz/trunk/framework/entity/servicedef/services_tenant.xml (added)
> +++ ofbiz/trunk/framework/entity/servicedef/services_tenant.xml Sat Sep
> 17 10:10:15 2016
> @@ -0,0 +1,42 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!--
> +Licensed to the Apache Software Foundation (ASF) under one
> +or more contributor license agreements.  See the NOTICE file
> +distributed with this work for additional information
> +regarding copyright ownership.  The ASF licenses this file
> +to you under the Apache License, Version 2.0 (the
> +"License"); you may not use this file except in compliance
> +with the License.  You may obtain a copy of the License at
> +
> +http://www.apache.org/licenses/LICENSE-2.0
> +
> +Unless required by applicable law or agreed to in writing,
> +software distributed under the License is distributed on an
> +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +KIND, either express or implied.  See the License for the
> +specific language governing permissions and limitations
> +under the License.
> +-->
> +
> +<services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> +        xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/
> services.xsd">
> +    <description>Entity Tenant Services</description>
> +    <vendor>OFBiz</vendor>
> +    <version>1.0</version>
> +
> +    <service name="createComponent" default-entity-name="Component"
> engine="entity-auto" invoke="create" auth="true">
> +        <description>Create a new Component Record</description>
> +        <auto-attributes mode="IN" include="pk"/>
> +        <auto-attributes mode="IN" include="nonpk" optional="true"/>
> +    </service>
> +    <service name="updateComponent" default-entity-name="Component"
> engine="entity-auto" invoke="update" auth="true">
> +        <description>Update a Component record</description>
> +        <auto-attributes include="pk" mode="IN"/>
> +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> +    </service>
> +    <service name="deleteComponent" default-entity-name="Component"
> engine="entity-auto" invoke="delete" auth="true">
> +        <description>Delete a Component record</description>
> +        <auto-attributes include="pk" mode="IN"/>
> +        <auto-attributes include="nonpk" mode="IN" optional="true"/>
> +    </service>
> +</services>
>
>
>