[GitHub] [airflow] dstandish commented on pull request #20759: Remove RefreshConfiguration workaround for K8s token refreshing

[GitBox <gi...@apache.org>]

dstandish commented on pull request #20759:
URL: https://github.com/apache/airflow/pull/20759#issuecomment-1007863486


   > What do you think? Do we need to merge it quickly or can we wait for the compatibility with the new version of the k8s client to mature?
   
   I have no objections to delaying.  
   
   Why I personally am invested in this change is, making this change will smooth the path to (1) making client creation consistent between k8s hook and internal k8s (e.g. used with k8s exec), (2) letting k8s pod operator use k8s hook, and (3) reducing dependencies between internal k8s and k8s provider.  But it's not a complete blocker to those efforts and we should do it in the right way, whatever that is.
   
   > This is a bit of a risky change, and I wonder if we should wait until we have at least one release that is compatible with a wide range of Kubernetes Client versions ie. until a provider package is released that is compatible with a old and a new version of Kubernetes client versions. See: #18797
   
   Yeah it sounds reasonable.  Once #18797 is out people will start getting the latest kubernetes library and we'll see what happens.  I think we may have to wait until next _airflow_ release to start getting feedback though... because i think people still won't be able to install kubernetes > 12 after only tomorrow's _provider_ patch release goes out because the versions are controllled by airflow.... I could be wrong about that though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org