You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philippe M. Chiasson" <go...@ectoplasm.org> on 2004/08/17 21:52:57 UTC
[Patch mp2] Apache::Module structure members read-only
The following ap_module_t fields are currently writable, and I can't think of a
good reason why they should be. As I am trying to finish the documentation for
Apache::Module, I'd like to suggest making the following fields read-only:
version
minor_version
module_index
name
next
cmds
Patch below.
Index: xs/maps/apache_structures.map
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/maps/apache_structures.map,v
retrieving revision 1.43
diff -u -I$Id -r1.43 apache_structures.map
--- xs/maps/apache_structures.map 13 Aug 2004 04:42:37 -0000 1.43
+++ xs/maps/apache_structures.map 17 Aug 2004 19:51:22 -0000
@@ -131,19 +131,19 @@
</server_addr_rec>
<module>
- version
- minor_version
- module_index
- name
+< version
+< minor_version
+< module_index
+< name
! dynamic_load_handle
- next
+< next
> magic
- rewrite_args
> create_dir_config
> merge_dir_config
> create_server_config
> merge_server_config
- cmds
+< cmds
> register_hooks
</module>
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: [Patch mp2] Apache::Module structure members read-only
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Stas Bekman wrote:
> Philippe M. Chiasson wrote:
>
>>The following ap_module_t fields are currently writable, and I can't
>>think of a
>>good reason why they should be. As I am trying to finish the
>>documentation for
>>Apache::Module, I'd like to suggest making the following fields read-only:
>>
>>version
>>minor_version
>>module_index
>>name
>>next
>>cmds
>
>
> +1
>
Gone!
>>Patch below.
>>
>>Index: xs/maps/apache_structures.map
>>===================================================================
>>RCS file: /home/cvs/modperl-2.0/xs/maps/apache_structures.map,v
>>retrieving revision 1.43
>>diff -u -I$Id -r1.43 apache_structures.map
>>--- xs/maps/apache_structures.map 13 Aug 2004 04:42:37 -0000
>>1.43
>>+++ xs/maps/apache_structures.map 17 Aug 2004 19:51:22 -0000
>>@@ -131,19 +131,19 @@
>> </server_addr_rec>
>>
>> <module>
>>- version
>>- minor_version
>>- module_index
>>- name
>>+< version
>>+< minor_version
>>+< module_index
>>+< name
>> ! dynamic_load_handle
>>- next
>>+< next
>> > magic
>> - rewrite_args
>> > create_dir_config
>> > merge_dir_config
>> > create_server_config
>> > merge_server_config
>>- cmds
>>+< cmds
>> > register_hooks
>> </module>
>>
>
>
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
Re: [Patch mp2] Apache::Module structure members read-only
Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> The following ap_module_t fields are currently writable, and I can't
> think of a
> good reason why they should be. As I am trying to finish the
> documentation for
> Apache::Module, I'd like to suggest making the following fields read-only:
>
> version
> minor_version
> module_index
> name
> next
> cmds
+1
> Patch below.
>
> Index: xs/maps/apache_structures.map
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/xs/maps/apache_structures.map,v
> retrieving revision 1.43
> diff -u -I$Id -r1.43 apache_structures.map
> --- xs/maps/apache_structures.map 13 Aug 2004 04:42:37 -0000
> 1.43
> +++ xs/maps/apache_structures.map 17 Aug 2004 19:51:22 -0000
> @@ -131,19 +131,19 @@
> </server_addr_rec>
>
> <module>
> - version
> - minor_version
> - module_index
> - name
> +< version
> +< minor_version
> +< module_index
> +< name
> ! dynamic_load_handle
> - next
> +< next
> > magic
> - rewrite_args
> > create_dir_config
> > merge_dir_config
> > create_server_config
> > merge_server_config
> - cmds
> +< cmds
> > register_hooks
> </module>
>
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org