You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/08/06 02:52:38 UTC
[20/51] [abbrv] incubator-beam git commit: [BEAM-475] Javadoc has
invalid references after the recent refactorings + other fixes
[BEAM-475] Javadoc has invalid references after the recent refactorings + other fixes
* Remove useless semicolons
* Remove unneeded java keywords/validations and fix Filter<T> style
* Fix invalid Javadoc references and some other documentation issues
* Add rules for unused semicolons and overcomplicated boolean expresions
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/032e1fa6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/032e1fa6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/032e1fa6
Branch: refs/heads/python-sdk
Commit: 032e1fa6b11a7474057df8ef553a5ba2d6cad63d
Parents: 3144363
Author: Isma�l Mej�a <ie...@gmail.com>
Authored: Wed Aug 3 11:03:43 2016 +0200
Committer: Dan Halperin <dh...@google.com>
Committed: Wed Aug 3 23:03:30 2016 -0700
----------------------------------------------------------------------
.../src/main/resources/beam/checkstyle.xml | 5 +++++
.../main/java/org/apache/beam/sdk/Pipeline.java | 2 +-
.../org/apache/beam/sdk/coders/JAXBCoder.java | 2 +-
.../java/org/apache/beam/sdk/io/AvroIO.java | 3 +--
.../org/apache/beam/sdk/io/FileBasedSink.java | 2 +-
.../java/org/apache/beam/sdk/io/PubsubIO.java | 6 +++---
.../org/apache/beam/sdk/io/package-info.java | 3 +--
.../beam/sdk/options/PipelineOptions.java | 2 +-
.../sdk/options/PipelineOptionsFactory.java | 2 +-
.../beam/sdk/testing/SerializableMatchers.java | 22 +++++++++++---------
.../apache/beam/sdk/transforms/CombineFns.java | 2 +-
.../beam/sdk/transforms/DoFnReflector.java | 4 ++--
.../apache/beam/sdk/transforms/DoFnTester.java | 2 +-
.../org/apache/beam/sdk/transforms/Filter.java | 5 ++---
.../beam/sdk/transforms/SimpleFunction.java | 2 +-
.../windowing/AfterProcessingTime.java | 5 +++--
.../beam/sdk/transforms/windowing/PaneInfo.java | 2 +-
.../beam/sdk/transforms/windowing/Window.java | 2 +-
.../org/apache/beam/sdk/util/TimeDomain.java | 2 +-
.../apache/beam/sdk/util/WindowingStrategy.java | 6 +++---
.../util/common/ElementByteSizeObserver.java | 2 +-
.../CopyOnAccessInMemoryStateInternals.java | 4 ++--
.../sdk/util/state/StateInternalsFactory.java | 4 ++--
.../beam/sdk/util/state/StateNamespaces.java | 2 +-
.../apache/beam/sdk/util/state/StateTags.java | 6 +++---
.../apache/beam/sdk/values/PCollectionList.java | 2 +-
.../org/apache/beam/sdk/values/POutput.java | 2 +-
.../org/apache/beam/sdk/values/TupleTag.java | 2 +-
.../beam/sdk/io/gcp/bigquery/BigQueryIO.java | 1 -
.../java/org/apache/beam/sdk/io/jms/JmsIO.java | 4 +---
.../org/apache/beam/sdk/io/kafka/KafkaIO.java | 2 +-
31 files changed, 57 insertions(+), 55 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml
----------------------------------------------------------------------
diff --git a/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml b/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml
index a437561..4bb7428 100644
--- a/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml
+++ b/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml
@@ -316,6 +316,11 @@ page at http://checkstyle.sourceforge.net/config.html -->
<property name="severity" value="error"/>
</module>
+ <!-- Checks for over-complicated boolean expressions. -->
+ <module name="SimplifyBooleanExpression"/>
+
+ <!-- Detects empty statements (standalone ";" semicolon). -->
+ <module name="EmptyStatement"/>
<!--
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
index 31ae2dc..e4f3e4a 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
@@ -250,7 +250,7 @@ public class Pipeline {
*/
public enum CompositeBehavior {
ENTER_TRANSFORM,
- DO_NOT_ENTER_TRANSFORM;
+ DO_NOT_ENTER_TRANSFORM
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java
index f90eb54..2284aaf 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/JAXBCoder.java
@@ -110,7 +110,7 @@ public class JAXBCoder<T> extends AtomicCoder<T> {
}
}
- private final JAXBContext getContext() throws JAXBException {
+ private JAXBContext getContext() throws JAXBException {
if (jaxbContext == null) {
synchronized (this) {
if (jaxbContext == null) {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
index 718461a..28c283d 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroIO.java
@@ -87,8 +87,7 @@ import javax.annotation.Nullable;
* the path of the file to write to (e.g., a local filename or sharded
* filename pattern if running locally, or a Google Cloud Storage
* filename or sharded filename pattern of the form
- * {@code "gs://<bucket>/<filepath>"}), and optionally
- * {@link AvroIO.Write#named} to specify the name of the pipeline step.
+ * {@code "gs://<bucket>/<filepath>"}).
*
* <p>It is required to specify {@link AvroIO.Write#withSchema}. To
* write specific records, such as Avro-generated classes, provide an
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
index 8246148..761d49c 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
@@ -207,7 +207,7 @@ public abstract class FileBasedSink<T> extends Sink<T> {
*/
public enum TemporaryFileRetention {
KEEP,
- REMOVE;
+ REMOVE
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubIO.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubIO.java
index 182fa1f..1902bca 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubIO.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/PubsubIO.java
@@ -365,9 +365,9 @@ public class PubsubIO {
* the stream.
*
* <p>When running with a {@link PipelineRunner} that only supports bounded
- * {@link PCollection PCollections} (such as {@link DirectRunner}),
- * only a bounded portion of the input Pub/Sub stream can be processed. As such, either
- * {@link Bound#maxNumRecords(int)} or {@link Bound#maxReadTime(Duration)} must be set.
+ * {@link PCollection PCollections}, only a bounded portion of the input Pub/Sub stream
+ * can be processed. As such, either {@link Bound#maxNumRecords(int)} or
+ * {@link Bound#maxReadTime(Duration)} must be set.
*/
public static class Read {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/io/package-info.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/package-info.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/package-info.java
index 432c5df..c4ff158 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/package-info.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/package-info.java
@@ -17,8 +17,7 @@
*/
/**
* Defines transforms for reading and writing common storage formats, including
- * {@link org.apache.beam.sdk.io.AvroIO},
- * {@link org.apache.beam.sdk.io.BigQueryIO}, and
+ * {@link org.apache.beam.sdk.io.AvroIO}, and
* {@link org.apache.beam.sdk.io.TextIO}.
*
* <p>The classes in this package provide {@code Read} transforms that create PCollections
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java
index aa9f13e..365f668 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptions.java
@@ -234,7 +234,7 @@ public interface PipelineOptions extends HasDisplayData {
public static enum CheckEnabled {
OFF,
WARNING,
- ERROR;
+ ERROR
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
index 67fa2af..a795fcd 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
@@ -920,7 +920,7 @@ public class PipelineOptionsFactory {
mismatch.setterPropertyType.getName()));
} else if (mismatches.size() > 1) {
StringBuilder builder = new StringBuilder(
- String.format("Type mismatches between getters and setters detected:"));
+ "Type mismatches between getters and setters detected:");
for (TypeMismatch mismatch : mismatches) {
builder.append(String.format(
"%n - Property [%s]: Getter is of type [%s] whereas setter is of type [%s].",
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/SerializableMatchers.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/SerializableMatchers.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/SerializableMatchers.java
index 4e0c0be..62a42e4 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/SerializableMatchers.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/SerializableMatchers.java
@@ -516,7 +516,7 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#equalTo()}.
+ * A {@link SerializableMatcher} with identical criteria to {@link Matchers#equalTo(Object)}.
*/
public static <T extends Serializable> SerializableMatcher<T> equalTo(final T expected) {
return fromSupplier(new SerializableSupplier<Matcher<T>>() {
@@ -528,7 +528,7 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#equalTo()}.
+ * A {@link SerializableMatcher} with identical criteria to {@link Matchers#equalTo(Object)}.
*
* <p>The expected value of type {@code T} will be serialized using the provided {@link Coder}.
* It is explicitly <i>not</i> required or expected to be serializable via Java serialization.
@@ -546,7 +546,8 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#greaterThan()}.
+ * A {@link SerializableMatcher} with identical criteria to
+ * {@link Matchers#greaterThan(Comparable)}.
*/
public static <T extends Comparable<T> & Serializable> SerializableMatcher<T>
greaterThan(final T target) {
@@ -559,7 +560,8 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#greaterThan()}.
+ * A {@link SerializableMatcher} with identical criteria to
+ * {@link Matchers#greaterThan(Comparable)}.
*
* <p>The target value of type {@code T} will be serialized using the provided {@link Coder}.
* It is explicitly <i>not</i> required or expected to be serializable via Java serialization.
@@ -577,7 +579,7 @@ class SerializableMatchers implements Serializable {
/**
* A {@link SerializableMatcher} with identical criteria to
- * {@link Matchers#greaterThanOrEqualTo()}.
+ * {@link Matchers#greaterThanOrEqualTo(Comparable)}.
*/
public static <T extends Comparable<T>> SerializableMatcher<T> greaterThanOrEqualTo(
final T target) {
@@ -591,7 +593,7 @@ class SerializableMatchers implements Serializable {
/**
* A {@link SerializableMatcher} with identical criteria to
- * {@link Matchers#greaterThanOrEqualTo()}.
+ * {@link Matchers#greaterThanOrEqualTo(Comparable)}.
*
* <p>The target value of type {@code T} will be serialized using the provided {@link Coder}.
* It is explicitly <i>not</i> required or expected to be serializable via Java serialization.
@@ -860,7 +862,7 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#lessThan()}.
+ * A {@link SerializableMatcher} with identical criteria to {@link Matchers#lessThan(Comparable)}.
*/
public static <T extends Comparable<T> & Serializable> SerializableMatcher<T> lessThan(
final T target) {
@@ -873,7 +875,7 @@ class SerializableMatchers implements Serializable {
}
/**
- * A {@link SerializableMatcher} with identical criteria to {@link Matchers#lessThan()}.
+ * A {@link SerializableMatcher} with identical criteria to {@link Matchers#lessThan(Comparable)}.
*
* <p>The target value of type {@code T} will be serialized using the provided {@link Coder}.
* It is explicitly <i>not</i> required or expected to be serializable via Java serialization.
@@ -891,7 +893,7 @@ class SerializableMatchers implements Serializable {
/**
* A {@link SerializableMatcher} with identical criteria to
- * {@link Matchers#lessThanOrEqualTo()}.
+ * {@link Matchers#lessThanOrEqualTo(Comparable)}.
*/
public static <T extends Comparable<T> & Serializable> SerializableMatcher<T> lessThanOrEqualTo(
final T target) {
@@ -905,7 +907,7 @@ class SerializableMatchers implements Serializable {
/**
* A {@link SerializableMatcher} with identical criteria to
- * {@link Matchers#lessThanOrEqualTo()}.
+ * {@link Matchers#lessThanOrEqualTo(Comparable)}.
*
* <p>The target value of type {@code T} will be serialized using the provided {@link Coder}.
* It is explicitly <i>not</i> required or expected to be serializable via Java serialization.
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
index 777deba..61f4888 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java
@@ -261,7 +261,7 @@ public class CombineFns {
public static class CoCombineResult implements Serializable {
private enum NullValue {
- INSTANCE;
+ INSTANCE
}
private final Map<TupleTag<?>, Object> valuesMap;
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnReflector.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnReflector.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnReflector.java
index b504cb4..9bdfde8 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnReflector.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnReflector.java
@@ -104,7 +104,7 @@ public abstract class DoFnReflector {
/** Indicates parameters only available in {@code @ProcessElement} methods. */
PROCESS_ELEMENT_ONLY,
/** Indicates parameters available in all methods. */
- EVERYWHERE;
+ EVERYWHERE
}
/**
@@ -445,7 +445,7 @@ public abstract class DoFnReflector {
anno, fnClazz, DoFn.class);
if (matches.size() == 0) {
- if (required == true) {
+ if (required) {
throw new IllegalStateException(String.format(
"No method annotated with @%s found in %s",
anno.getSimpleName(), fnClazz.getName()));
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
index f44a9ae..8de1066 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnTester.java
@@ -132,7 +132,7 @@ public class DoFnTester<InputT, OutputT> {
*/
public enum CloningBehavior {
CLONE,
- DO_NOT_CLONE;
+ DO_NOT_CLONE
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java
index 4466874..37cbec1 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java
@@ -202,15 +202,14 @@ public class Filter<T> extends PTransform<PCollection<T>, PCollection<T>> {
@Override
public PCollection<T> apply(PCollection<T> input) {
- PCollection<T> output = input.apply(ParDo.of(new OldDoFn<T, T>() {
+ return input.apply(ParDo.of(new OldDoFn<T, T>() {
@Override
public void processElement(ProcessContext c) {
- if (predicate.apply(c.element()) == true) {
+ if (predicate.apply(c.element())) {
c.output(c.element());
}
}
}));
- return output;
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java
index 6623c6a..8894352 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/SimpleFunction.java
@@ -22,7 +22,7 @@ import org.apache.beam.sdk.values.TypeDescriptor;
/**
* A {@link SerializableFunction} which is not a <i>functional interface</i>.
* Concrete subclasses allow us to infer type information, which in turn aids
- * {@link Coder} inference.
+ * {@link org.apache.beam.sdk.coders.Coder Coder} inference.
*/
public abstract class SimpleFunction<InputT, OutputT>
implements SerializableFunction<InputT, OutputT> {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java
index 324ab08..4c792df 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterProcessingTime.java
@@ -32,8 +32,9 @@ import javax.annotation.Nullable;
* {@code AfterProcessingTime} triggers fire based on the current processing time. They operate in
* the real-time domain.
*
- * <p>The time at which to fire the timer can be adjusted via the methods in {@link TimeTrigger},
- * such as {@link TimeTrigger#plusDelayOf} or {@link TimeTrigger#alignedTo}.
+ * <p>The time at which to fire the timer can be adjusted via the methods in
+ * {@link AfterDelayFromFirstElement}, such as {@link AfterDelayFromFirstElement#plusDelayOf} or
+ * {@link AfterDelayFromFirstElement#alignedTo}.
*/
@Experimental(Experimental.Kind.TRIGGER)
public class AfterProcessingTime extends AfterDelayFromFirstElement {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
index 7917aec..6ec17f9 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
@@ -126,7 +126,7 @@ public final class PaneInfo {
* This element was not produced in a triggered pane and its relation to input and
* output watermarks is unknown.
*/
- UNKNOWN;
+ UNKNOWN
// NOTE: Do not add fields or re-order them. The ordinal is used as part of
// the encoding.
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java
index 03ff481..5b6f4c8 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java
@@ -155,7 +155,7 @@ public class Window {
*
* <p>This is the default behavior.
*/
- FIRE_IF_NON_EMPTY;
+ FIRE_IF_NON_EMPTY
}
/**
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimeDomain.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimeDomain.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimeDomain.java
index f03446e..4c93e56 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimeDomain.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/TimeDomain.java
@@ -39,5 +39,5 @@ public enum TimeDomain {
* {@code T} until all timers from earlier stages set for a time earlier than {@code T} have
* fired.
*/
- SYNCHRONIZED_PROCESSING_TIME;
+ SYNCHRONIZED_PROCESSING_TIME
}
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowingStrategy.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowingStrategy.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowingStrategy.java
index 19b11cd..f5ae812 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowingStrategy.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowingStrategy.java
@@ -53,7 +53,7 @@ public class WindowingStrategy<T, W extends BoundedWindow> implements Serializab
*/
public enum AccumulationMode {
DISCARDING_FIRED_PANES,
- ACCUMULATING_FIRED_PANES;
+ ACCUMULATING_FIRED_PANES
}
private static final Duration DEFAULT_ALLOWED_LATENESS = Duration.ZERO;
@@ -278,8 +278,8 @@ public class WindowingStrategy<T, W extends BoundedWindow> implements Serializab
*
* <ul>
* <li>The {@link WindowFn#getOutputTime} allows adjustments such as that whereby
- * {@link SlidingWindows#getOutputTime} moves elements later in time to avoid holding up
- * progress downstream.</li>
+ * {@link org.apache.beam.sdk.transforms.windowing.SlidingWindows#getOutputTime}
+ * moves elements later in time to avoid holding up progress downstream.</li>
* <li>Then, when multiple elements are buffered for output, the output timestamp of the
* result is calculated using {@link OutputTimeFn#combine}.</li>
* <li>In the case of a merging {@link WindowFn}, the output timestamp when windows merge
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObserver.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObserver.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObserver.java
index 53dd4b9..3e7011b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObserver.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObserver.java
@@ -49,7 +49,7 @@ public class ElementByteSizeObserver implements Observer {
if (counter != null) {
counter.addValue(elementByteSize);
}
- };
+ }
/**
* Sets byte counting for the current element as lazy. That is, the
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/CopyOnAccessInMemoryStateInternals.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/CopyOnAccessInMemoryStateInternals.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/CopyOnAccessInMemoryStateInternals.java
index 3850f04..3cc34a6 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/CopyOnAccessInMemoryStateInternals.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/CopyOnAccessInMemoryStateInternals.java
@@ -122,8 +122,8 @@ public class CopyOnAccessInMemoryStateInternals<K> implements StateInternals<K>
/**
* A {@link StateTable} that, when a value is retrieved with
- * {@link StateTable#get(StateNamespace, StateTag)}, first attempts to obtain a copy of existing
- * {@link State} from an underlying {@link StateTable}.
+ * {@link StateTable#get(StateNamespace, StateTag, StateContext)}, first attempts to obtain a
+ * copy of existing {@link State} from an underlying {@link StateTable}.
*/
private static class CopyOnAccessInMemoryStateTable<K> extends StateTable<K> {
private final K key;
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateInternalsFactory.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateInternalsFactory.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateInternalsFactory.java
index 54355c7..05c3b77 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateInternalsFactory.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateInternalsFactory.java
@@ -25,8 +25,8 @@ import java.io.Serializable;
/**
* A factory for providing {@link StateInternals} for a particular key.
*
- * <p>Because it will generally be embedded in a {@link DoFn}, albeit at execution time,
- * it is marked {@link Serializable}.
+ * <p>Because it will generally be embedded in a {@link org.apache.beam.sdk.transforms.DoFn DoFn},
+ * albeit at execution time, it is marked {@link Serializable}.
*/
@Experimental(Kind.STATE)
public interface StateInternalsFactory<K> {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespaces.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespaces.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespaces.java
index b8de27f..bfee976 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespaces.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateNamespaces.java
@@ -36,7 +36,7 @@ public class StateNamespaces {
private enum Namespace {
GLOBAL,
WINDOW,
- WINDOW_AND_TRIGGER;
+ WINDOW_AND_TRIGGER
}
public static StateNamespace global() {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java
index 1e23ae2..e50ad8d 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/state/StateTags.java
@@ -304,7 +304,7 @@ public class StateTags {
}
@Override
- public ValueState<T> bind(StateBinder<? extends Object> visitor) {
+ public ValueState<T> bind(StateBinder<?> visitor) {
return visitor.bindValue(this, coder);
}
@@ -505,7 +505,7 @@ public class StateTags {
}
@Override
- public BagState<T> bind(StateBinder<? extends Object> visitor) {
+ public BagState<T> bind(StateBinder<?> visitor) {
return visitor.bindBag(this, elemCoder);
}
@@ -551,7 +551,7 @@ public class StateTags {
}
@Override
- public WatermarkHoldState<W> bind(StateBinder<? extends Object> visitor) {
+ public WatermarkHoldState<W> bind(StateBinder<?> visitor) {
return visitor.bindWatermark(this, outputTimeFn);
}
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionList.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionList.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionList.java
index 0cf4f49..01acca7 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionList.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionList.java
@@ -128,7 +128,7 @@ public class PCollectionList<T> implements PInput, POutput {
* this {@link PCollectionList} plus the given {@link PCollection PCollections} appended to the
* end, in order.
*
- * <p>All the {@link PCollections} in the resulting {@link PCollectionList} must be
+ * <p>All the {@link PCollection PCollections} in the resulting {@link PCollectionList} must be
* part of the same {@link Pipeline}.
*/
public PCollectionList<T> and(Iterable<PCollection<T>> pcs) {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/values/POutput.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/POutput.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/POutput.java
index 01e4b36..299d55d 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/POutput.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/POutput.java
@@ -66,7 +66,7 @@ public interface POutput {
* output to make it ready for being used as an input and for running.
*
* <p>This includes ensuring that all {@link PCollection PCollections}
- * have {@link Coder Coders} specified or defaulted.
+ * have {@link org.apache.beam.sdk.coders.Coder Coders} specified or defaulted.
*
* <p>Automatically invoked whenever this {@link POutput} is used
* as a {@link PInput} to another {@link PTransform}, or if never
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/core/src/main/java/org/apache/beam/sdk/values/TupleTag.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/TupleTag.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/TupleTag.java
index ea06479..b281a43 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/values/TupleTag.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/values/TupleTag.java
@@ -39,7 +39,7 @@ import java.util.Random;
* Its generic type parameter allows tracking
* the static type of things stored in tuples.
*
- * <p>To aid in assigning default {@link Coder Coders} for results of
+ * <p>To aid in assigning default {@link org.apache.beam.sdk.coders.Coder Coders} for results of
* side outputs of {@link ParDo}, an output
* {@link TupleTag} should be instantiated with an extra {@code {}} so
* it is an instance of an anonymous subclass without generic type
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
index 9fccbf9..8741c9c 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
@@ -926,7 +926,6 @@ public class BigQueryIO {
if (parseStatus(job) != Status.SUCCEEDED) {
throw new IOException("Query job failed: " + jobId);
}
- return;
}
private void readObject(ObjectInputStream in) throws ClassNotFoundException, IOException {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java b/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
index 342c4fc..eeb02e6 100644
--- a/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
+++ b/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
@@ -474,9 +474,7 @@ public class JmsIO {
if (producer == null) {
this.connection = connectionFactory.createConnection();
this.connection.start();
- /**
- * false means we don't use JMS transaction.
- */
+ // false means we don't use JMS transaction.
this.session = this.connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
Destination destination;
if (queue != null) {
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/032e1fa6/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
index eb649a6..2271216 100644
--- a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
+++ b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
@@ -1059,7 +1059,7 @@ public class KafkaIO {
try {
offsetConsumer.seekToEnd(p.topicPartition);
long offset = offsetConsumer.position(p.topicPartition);
- p.setLatestOffset(offset);;
+ p.setLatestOffset(offset);
} catch (Exception e) {
LOG.warn("{}: exception while fetching latest offsets. ignored.", this, e);
p.setLatestOffset(-1L); // reset