[GitHub] spark pull request #13399: [SPARK-15620][SQL] Fix transformed dataset attrib...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13399#discussion_r65454175
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -783,6 +783,16 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
           ds.filter(_.b > 1).collect().toSeq
         }
       }
    +
    +  test("transformed dataset correctly solve the attributes") {
    +    val dataset = Seq(1, 2, 3).toDS()
    +    val ds1 = dataset.map(_ + 1)
    --- End diff --
    
    nit: I'd like it to be:
    ```
    val ds = Seq(1, 2, 3).toDS().map(_ + 1)
    val d1 = ds.as("d1")
    val d2 = ds.as("d2")
    ...
    ```
    
    and the test name can be: `mapped dataset should resolve duplicated attributes for self join and set operations`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org