You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/17 21:09:04 UTC

[jira] [Commented] (OPENNLP-979) Update Lemmatizer documentation according to OPENNLP-904

    [ https://issues.apache.org/jira/browse/OPENNLP-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014773#comment-16014773 ] 

ASF GitHub Bot commented on OPENNLP-979:
----------------------------------------

GitHub user ragerri opened a pull request:

    https://github.com/apache/opennlp/pull/210

    OPENNLP-979: Update lemmatizer doc after API change

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ragerri/opennlp opennlp-979

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #210
    
----
commit ee9fdb8aad0e4c43bba85e50be3687475bf2221d
Author: Rodrigo Agerri <ra...@apache.org>
Date:   2017-05-17T21:04:23Z

    OPENNLP-979 Update lemmatizer doc after API change

----


> Update Lemmatizer documentation according to OPENNLP-904
> --------------------------------------------------------
>
>                 Key: OPENNLP-979
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-979
>             Project: OpenNLP
>          Issue Type: Documentation
>            Reporter: Rodrigo Agerri
>            Assignee: Rodrigo Agerri
>            Priority: Minor
>             Fix For: 1.8.1
>
>
> Documentation needs to be changed to reflect the changes in the Lemmatizer API implemented in OPENNLP-904



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)