You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2020/06/10 23:21:53 UTC

[Impala-ASF-CR] IMPALA-8830: Fix executor group assignment of coordinator only queries

Hello Andrew Sherman, Lars Volker, Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14183

to look at the new patch set (#7).

Change subject: IMPALA-8830: Fix executor group assignment of coordinator only queries
......................................................................

IMPALA-8830: Fix executor group assignment of coordinator only queries

With this fix, coordinator only queries are submitted to a pseudo
executor group named "empty group (using coordinator only)" which
is empty. This allows running coordinator only queries regardless
of the presence of any healthy executor groups.

Testing:
Added a custom cluster test and modified tests that relied on
coordinator only queries to be queued in absence of executor groups.

Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
M tests/custom_cluster/test_executor_groups.py
7 files changed, 98 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/14183/7
-- 
To view, visit http://gerrit.cloudera.org:8080/14183
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8fe098032744aa20bbbe4faddfc67e7a46ce03d5
Gerrit-Change-Number: 14183
Gerrit-PatchSet: 7
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>