You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2016/01/05 02:03:47 UTC
Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Fixed posix filesystem isolator to not allow executors with image.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
Diff: https://reviews.apache.org/r/41909/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112772
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 5, 2016, 5:09 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 5:09 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
>
> Diff: https://reviews.apache.org/r/41909/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 5:09 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290
Repository: mesos
Description
-------
Fixed posix filesystem isolator to not allow executors with image.
Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
Diff: https://reviews.apache.org/r/41909/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112725
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 4, 2016, 5:06 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 5:06 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
>
> Diff: https://reviews.apache.org/r/41909/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/#review112738
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 81 - 82)
<https://reviews.apache.org/r/41909/#comment173223>
Can you move the comments right above:
```
if (executorInfo.container().mesos().has_image()) {
```
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 91 - 93)
<https://reviews.apache.org/r/41909/#comment173224>
In fact, we don't support executorInfo.container().volumes() at all. Let's disallow that as well:
```
if (!executorInfo.container().volumes().empty()) {
return Failure("Volumes in ContainerInfo is not supported");
}
```
- Jie Yu
On Jan. 5, 2016, 1:06 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41909/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 1:06 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-4290
> https://issues.apache.org/jira/browse/MESOS-4290
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed posix filesystem isolator to not allow executors with image.
> Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
>
> Diff: https://reviews.apache.org/r/41909/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 1:06 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290
Repository: mesos
Description (updated)
-------
Fixed posix filesystem isolator to not allow executors with image.
Note that command tasks with image also creates a volume in the executor info, so this check should handle both command tasks and custom executors.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
Diff: https://reviews.apache.org/r/41909/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 41909: Fixed posix filesystem isolator to not allow
executors with image.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41909/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 1:04 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-4290
https://issues.apache.org/jira/browse/MESOS-4290
Repository: mesos
Description
-------
Fixed posix filesystem isolator to not allow executors with image.
Diffs
-----
src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 00ff84b6cd0aa29fa5a7918d7f88d480af8752ca
Diff: https://reviews.apache.org/r/41909/diff/
Testing
-------
make check
Thanks,
Timothy Chen