You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Elijah Zupancic (Created) (JIRA)" <ji...@apache.org> on 2011/10/06 18:45:29 UTC

[jira] [Created] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Chain 2.0 trunk build is throwing many warnings as a result of generification changes
-------------------------------------------------------------------------------------

                 Key: CHAIN-61
                 URL: https://issues.apache.org/jira/browse/CHAIN-61
             Project: Commons Chain
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: Elijah Zupancic
             Fix For: 2.0


When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135390#comment-13135390 ] 

Simone Tripodi commented on CHAIN-61:
-------------------------------------

Hi Elijah,
thanks for your contribution! Unfortunately I sadly got issues when applying the patch :(

{code}
commons-chain simonetripodi$ patch -p0 < ~/Downloads/chain-61.diff 
patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingFilter.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/test/java/org/apache/commons/chain/impl/DelegatingFilter.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/impl/ContextBase.java
Hunk #1 succeeded at 52 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/impl/CatalogBase.java
patching file src/main/java/org/apache/commons/chain/config/ConfigParser.java
patching file src/main/java/org/apache/commons/chain/config/ConfigRegisterRule.java
patching file src/main/java/org/apache/commons/chain/web/faces/FacesWebContext.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletPathMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/PathInfoMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletParamValuesMap.java
patching file src/main/java/org/apache/commons/chain/web/servlet/RequestParameterMapper.java
patching file src/main/java/org/apache/commons/chain/web/ChainListener.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
patching file src/main/java/org/apache/commons/chain/web/ChainResources.java
{code}

Can you help me please? Many thanks in advance!
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-61:
---------------------------------

    Attachment: chain-61.diff
    
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122167#comment-13122167 ] 

Simone Tripodi commented on CHAIN-61:
-------------------------------------

thanks once again for your work! I'd like to ask you to provide another patch where {{@SuppressWarnings("unchecked")}} are accompanied by a comment where it is justified why the warning can be suppressed.
Many thanks in advance!
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135740#comment-13135740 ] 

Simone Tripodi commented on CHAIN-61:
-------------------------------------

Thanks for the suggestions Phil, more than appreciated!
And thanks Elijah for the patch. I just committed the modifications, see [r1189035|https://svn.apache.org/viewvc?view=revision&revision=1189035]
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-61:
---------------------------------

    Attachment: chain-61.diff
    
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135513#comment-13135513 ] 

Elijah Zupancic commented on CHAIN-61:
--------------------------------------

I have attached another patch to the ticket. I just did a svn update and I
noticed that the version number increased but there was no change in the
files themselves. I just ran the patch, then created a new patch from those
changes and I'm still getting the fuzz warning. I assume that it is
informing us about some condition in that patching process - can we just
ignore it?

On Tue, Oct 25, 2011 at 1:54 PM, Simone Tripodi (Commented) (JIRA) <


                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-61:
---------------------------------

    Attachment:     (was: chain-61.diff)
    
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-61:
---------------------------------

    Attachment:     (was: chain-61.diff)
    
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135413#comment-13135413 ] 

Elijah Zupancic commented on CHAIN-61:
--------------------------------------

Hi Simo,

I'm not sure that I understand the errors below. Does a fuzz of one mean
that there is a single character difference in whitespace? Outside of the
patch warnings, did the patch succeed?

I'm doing: svn diff > chain-61.diff

Does anyone have any advice on making patches?
http://httpd.apache.org/dev/patches.html just advises me to use unified
diffs and that's what svn uses by default. Since this is the second time
that this type of thing has happened, it leaves me wandering if I have some
sort of configuration issue with svn.

Thanks,
-Elijah


On Tue, Oct 25, 2011 at 1:18 PM, Simone Tripodi (Commented) (JIRA) <


                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Elijah Zupancic (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elijah Zupancic updated CHAIN-61:
---------------------------------

    Attachment: chain-61.diff

Updated patch containing comments on suppressed warnings.
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135416#comment-13135416 ] 

Simone Tripodi commented on CHAIN-61:
-------------------------------------

Hi Elijah,
that is exactly the same way we use at [commons|http://commons.apache.org/patches.html] :(

Maybe is my svn configuration?

{code}
$ svn --version
svn, version 1.6.16 (r1073529)
   compiled Jun 13 2011, 15:54:33

Copyright (C) 2000-2009 CollabNet.
Subversion is open source software, see http://subversion.apache.org/
This product includes software developed by CollabNet (http://www.Collab.Net/).

The following repository access (RA) modules are available:

* ra_neon : Module for accessing a repository via WebDAV protocol using Neon.
  - handles 'http' scheme
  - handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network protocol.
  - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
{code}
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Phil Steitz (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135462#comment-13135462 ] 

Phil Steitz commented on CHAIN-61:
----------------------------------

Usually this is the result of some change being committed between the time the patch was created and when you are trying to apply it.  Succeeded usually means succeeded - i.e., the patch command was successful in figuring out how to adjust for the changes in the file.  What I do in these cases is compare what I get doing svn diff locally *after* applying the patch to the patch itself.  It the changes are the same (and of course, I am happy with the patch), I go ahead and commit.  I don't know about the content of this patch, but the patch itself looks fine to me.
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CHAIN-61) Chain 2.0 trunk build is throwing many warnings as a result of generification changes

Posted by "Simone Tripodi (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CHAIN-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi resolved CHAIN-61.
---------------------------------

    Resolution: Fixed
      Assignee: Simone Tripodi

Fixed on /trunk, see [r1189035|https://svn.apache.org/viewvc?view=revision&revision=1189035]
                
> Chain 2.0 trunk build is throwing many warnings as a result of generification changes
> -------------------------------------------------------------------------------------
>
>                 Key: CHAIN-61
>                 URL: https://issues.apache.org/jira/browse/CHAIN-61
>             Project: Commons Chain
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>            Assignee: Simone Tripodi
>             Fix For: 2.0
>
>         Attachments: chain-61.diff
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira