You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Yifan Mai (Jira)" <ji...@apache.org> on 2021/02/02 01:55:00 UTC

[jira] [Commented] (BEAM-11700) Optimizations skipped in PortableRunner when pre_optimize is 'default' or 'all'

    [ https://issues.apache.org/jira/browse/BEAM-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276791#comment-17276791 ] 

Yifan Mai commented on BEAM-11700:
----------------------------------

No progress today. The PR seems to generate actual test breakages. I will attempt to debug this tomorrow. In particular, I am trying to get a version of optimized portable runner tests to work (the tests were disabled before). If this still doesn't work tomorrow, I will instead revert to as close as possible to the state immediately before #13573, with optimized portable runner tests disabled.

> Optimizations skipped in PortableRunner when pre_optimize is 'default' or 'all'
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-11700
>                 URL: https://issues.apache.org/jira/browse/BEAM-11700
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Yifan Mai
>            Assignee: Yifan Mai
>            Priority: P2
>             Fix For: 2.28.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> An indentation error in portable_runner.py is causing optimizations to not run when pre_optimize is set to default or all. This was broken by [#13573|https://github.com/apache/beam/pull/13573].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)