You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Behlendorf <br...@hyperreal.org> on 1998/05/20 01:26:46 UTC
piped logs
At 10:18 PM 5/19/98 +0100, Ben Laurie wrote:
>Oh yeah - BTW, the things that are doing piped logs should really use
>ap_open_piped_log, which will reduce the pain (as well as making them
>better).
Hmm - http_log itself doesn't use ap_open_piped_logs to open the ErrorLog.
Should it?
When I try and apply the same deal I did for the other modules, I get a
cast warning of reassignment - and indeed, s->error_log is defined as a
FILE * whereas ap_piped_log_write_fd returns an int. It looks like
changing the definition of error_log from a FILE * to an int could be
problematic, since "stderr" is by C standards a FILE *.
For now I'm not going to worry about it I guess, but if anyone's inclined...
Brian
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction brian@apache.org
brian@hyperreal.org
Re: piped logs
Posted by Dean Gaudet <dg...@arctic.org>.
Incidentally, in apache-nspr I changed error_log to a PRFileDesc * ...
which most closely resembles an int. Well it would, if microsoft wasn't
so goddamn lame.
Dean
On Tue, 19 May 1998, Brian Behlendorf wrote:
> At 09:38 PM 5/19/98 -0700, you wrote:
> >You need to bcreate() to create a BUFF and then bpushfd() the descriptor
> >returned from ap_piped_log_write_fd. Also mark it unbuffered. That gives
> >you a BUFF *... not sure if that's the right solution I haven't had a
> >chance to look at Ben's stuff yet.
>
> I'll leave it alone for now, and not consider it a showstopper for 1.3.0.
>
> Brian
>
>
> --=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
> pure chewing satisfaction brian@apache.org
> brian@hyperreal.org
>
Re: piped logs
Posted by Brian Behlendorf <br...@hyperreal.org>.
At 09:38 PM 5/19/98 -0700, you wrote:
>You need to bcreate() to create a BUFF and then bpushfd() the descriptor
>returned from ap_piped_log_write_fd. Also mark it unbuffered. That gives
>you a BUFF *... not sure if that's the right solution I haven't had a
>chance to look at Ben's stuff yet.
I'll leave it alone for now, and not consider it a showstopper for 1.3.0.
Brian
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction brian@apache.org
brian@hyperreal.org
Re: piped logs
Posted by Dean Gaudet <dg...@arctic.org>.
On Tue, 19 May 1998, Brian Behlendorf wrote:
> When I try and apply the same deal I did for the other modules, I get a
> cast warning of reassignment - and indeed, s->error_log is defined as a
> FILE * whereas ap_piped_log_write_fd returns an int. It looks like
> changing the definition of error_log from a FILE * to an int could be
> problematic, since "stderr" is by C standards a FILE *.
You need to bcreate() to create a BUFF and then bpushfd() the descriptor
returned from ap_piped_log_write_fd. Also mark it unbuffered. That gives
you a BUFF *... not sure if that's the right solution I haven't had a
chance to look at Ben's stuff yet.
Dean