You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 11:51:51 UTC

[GitHub] [beam] iemejia commented on pull request #11357: [BEAM-7770] Add ReadAll transform for SolrIO

iemejia commented on pull request #11357:
URL: https://github.com/apache/beam/pull/11357#issuecomment-634608874


   `readAll()` is already tested. Notice that `read()` was refactored to rely on `readAll()` in line 392. I can write an extra test if you prefer but it is just duplication because it is already covered. Should I write the extra test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org