[GitHub] [geode] upthewaterspout commented on issue #4078: GEODE-7226: Ignore @Immutable classes in PMD

["upthewaterspout (GitHub)" <gi...@apache.org>]

I guess I'm in favor of not merging this PR.

Originally I was hoping we could just use `@Immutable` like the JCP annotation - putting it on a class would mean instances of the class are immutable. Then PMD could enforce that static final fields only to refer to `@Immutable` classes. So the fact that you can put `@Immutable` on a static field is really more of a workaround to the limitations of PMD, and maybe the fact that some static fields don't refer to immutable classes that we control.

I agree there is probably more value in using `@Immutable` on a class as documentation that the *instances* of the class are immutable. 

[ Full content available at: https://github.com/apache/geode/pull/4078 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org