You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by "Kami (via GitHub)" <gi...@apache.org> on 2023/08/04 13:49:35 UTC

[GitHub] [libcloud] Kami commented on pull request #1891: Fix list_volumes in the Azure arm driver

Kami commented on PR #1891:
URL: https://github.com/apache/libcloud/pull/1891#issuecomment-1665638419

   To be able to merge this PR I applied similar guard I added in the list_nodes() PR (d9f6268a2ec0211219e21b1e4f56813d265e62f1) - https://github.com/apache/libcloud/pull/1850#issuecomment-1658422834
   
   It's not ideal and it would need some refactor love to handle pagination in a standard manner across the methods and to avoid duplication, but it's better than noting having any guard at all.
   
   If you think timeout should be adjusted (e.g. increased), please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org