You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/06/13 21:30:14 UTC
[kudu-CR] [docs] Add rebalancing tool documentation
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10710
Change subject: [docs] Add rebalancing tool documentation
......................................................................
[docs] Add rebalancing tool documentation
Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
---
M docs/administration.adoc
1 file changed, 81 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/10710/1
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc@1118
PS1, Line 1118: No
> Is there extra configuration required to run the rebalancer against tserver
Ignored. Rebalancing will function like those tables do not exist. I added a note clarifying this.
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc@1119
PS1, Line 1119: 1.7.1 +<=+ v
> Nit: Personally I would find "v >= 1.7.1" to be more clear.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 17:26:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc@1118
PS1, Line 1118: No
Is there extra configuration required to run the rebalancer against tservers with single-replica tablets, or will they be ignored?
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:44:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Mike Percy, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10710
to look at the new patch set (#2).
Change subject: [docs] Add rebalancing tool documentation
......................................................................
[docs] Add rebalancing tool documentation
Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
---
M docs/administration.adoc
1 file changed, 85 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/10710/2
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 16 Jun 2018 00:13:03 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
[docs] Add rebalancing tool documentation
Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Reviewed-on: http://gerrit.cloudera.org:8080/10710
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M docs/administration.adoc
1 file changed, 85 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 2: Code-Review+1
Will defer to Andrew.
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 18:31:43 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/10710/1/docs/administration.adoc@1119
PS1, Line 1119: 1.7.1 +<=+ v
Nit: Personally I would find "v >= 1.7.1" to be more clear.
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:33:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add rebalancing tool documentation
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10710 )
Change subject: [docs] Add rebalancing tool documentation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28ba748f659c30bfbb45a5af101c0c29de4ec7c8
Gerrit-Change-Number: 10710
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 15 Jun 2018 23:17:59 +0000
Gerrit-HasComments: No