[GitHub] [orc] abstractdog commented on pull request #1166: ORC-1205: Size of batches in some ConvertTreeReaders should be ensured before using

[GitBox <gi...@apache.org>]

abstractdog commented on PR #1166:
URL: https://github.com/apache/orc/pull/1166#issuecomment-1165296502

   thanks for the comments so far!
   
   @dongjoon-hyun: hive is on ORC 1.6.9, so I'm motivated to backport the patch to branch-1.6 too if it can make its way to at least a single release, but if it becomes EOL, I don't mind, we're fixing this on 1.7.x too, hive should upgrade eventually anyway :)
   
   @guiyanakuang: can you please elaborate on this:
   ```
   in the Various TreeReaderImpl code path we had the ensureSize method being called repeatedly
   ```
   it's not clear where exactly this happens, and why it is a problem, but otherwise, I'm fine with fixing this on ConvertTreeReaders only: so did you mean that the ensureSize method can stay exposed in TypeReader interface (as it is in the current patch), and let it be a no-op in TreeReaderFactory (so ConvertTreeReader will implement it instead of calling super.ensureSize)?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org