You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/05/31 09:54:01 UTC
[PR] build with pekko 1.1 [pekko-connectors-kafka]
pjfanning opened a new pull request, #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187
* most pekko repos now use pekko 1.1 dependencies in main branch
* add nightly test run that checks code still works with pekko 1.0 libs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with pekko 1.1 [pekko-connectors-kafka]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187#discussion_r1624174046
##########
.github/workflows/nightly-pekko1.0.yml:
##########
@@ -0,0 +1,88 @@
+name: Nightly Test with Pekko 1.0 libs
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 2 * * *"
+
+permissions: {}
+
+concurrency:
+ group: ${{ github.workflow }} @ ${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ PEKKO_TEST_TIMEFACTOR: 10.0
+ EVENT_NAME: ${{ github.event_name }}
+
+jobs:
+ test:
+ name: Build and Test with Pekko 1.0
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { java-version: 8, scala-version: 2.12, sbt-opts: '' }
+ - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 3.3, sbt-opts: '' }
Review Comment:
Can we add the field 'pekko-version' to this, and then reduce the action.yml file? that may make life easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with pekko 1.1 [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with pekko 1.1 [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187#discussion_r1624573646
##########
.github/workflows/nightly-pekko.yml:
##########
@@ -0,0 +1,91 @@
+name: Nightly Test
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 2 * * *"
+
+permissions: {}
+
+concurrency:
+ group: ${{ github.workflow }} @ ${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ PEKKO_TEST_TIMEFACTOR: 10.0
+ EVENT_NAME: ${{ github.event_name }}
+
+jobs:
+ test:
+ name: Build and Test with Pekko 1.0
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { java-version: 8, scala-version: 2.12, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 2.12, pekko-version: 'main' }
+ - { java-version: 8, scala-version: 2.13, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 2.13, pekko-version: 'main' }
+ - { java-version: 8, scala-version: 3.3, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 3.3, pekko-version: 'main' }
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ fetch-tags: true
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java ${{ matrix.java-version }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: ${{ matrix.java-version }}
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6
+
+ - name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{ matrix.java-version }}
+ run: sbt -Dpekko.build.pekko.version=1.0.x "++${{ matrix.scala-version }} test" ${{ matrix.sbt-opts }}
Review Comment:
apologies - I made changes in Visual Studio but didn't save them properly before updating the PR - I've pushed the correct changes now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with pekko 1.1 [pekko-connectors-kafka]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187#discussion_r1624191126
##########
.github/workflows/nightly-pekko1.0.yml:
##########
@@ -0,0 +1,88 @@
+name: Nightly Test with Pekko 1.0 libs
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 2 * * *"
+
+permissions: {}
+
+concurrency:
+ group: ${{ github.workflow }} @ ${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ PEKKO_TEST_TIMEFACTOR: 10.0
+ EVENT_NAME: ${{ github.event_name }}
+
+jobs:
+ test:
+ name: Build and Test with Pekko 1.0
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { java-version: 8, scala-version: 2.12, sbt-opts: '' }
+ - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 3.3, sbt-opts: '' }
Review Comment:
fair point - I've committed a change - can you review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] build with pekko 1.1 [pekko-connectors-kafka]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #187:
URL: https://github.com/apache/pekko-connectors-kafka/pull/187#discussion_r1624558212
##########
.github/workflows/nightly-pekko.yml:
##########
@@ -0,0 +1,91 @@
+name: Nightly Test
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: "0 2 * * *"
+
+permissions: {}
+
+concurrency:
+ group: ${{ github.workflow }} @ ${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ PEKKO_TEST_TIMEFACTOR: 10.0
+ EVENT_NAME: ${{ github.event_name }}
+
+jobs:
+ test:
+ name: Build and Test with Pekko 1.0
+ runs-on: ubuntu-22.04
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - { java-version: 8, scala-version: 2.12, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 2.12, pekko-version: 'main' }
+ - { java-version: 8, scala-version: 2.13, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 2.13, pekko-version: 'main' }
+ - { java-version: 8, scala-version: 3.3, pekko-version: '1.0.x' }
+ - { java-version: 8, scala-version: 3.3, pekko-version: 'main' }
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ fetch-tags: true
+
+ - name: Checkout GitHub merge
+ if: github.event.pull_request
+ run: |-
+ git fetch origin pull/${{ github.event.pull_request.number }}/merge:scratch
+ git checkout scratch
+
+ - name: Setup Java ${{ matrix.java-version }}
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: ${{ matrix.java-version }}
+
+ - name: Cache Coursier cache
+ uses: coursier/cache-action@v6
+
+ - name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{ matrix.java-version }}
+ run: sbt -Dpekko.build.pekko.version=1.0.x "++${{ matrix.scala-version }} test" ${{ matrix.sbt-opts }}
Review Comment:
```suggestion
- name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{ matrix.java-version }} on ${{ matrix.pekko-version }}
run: sbt -Dpekko.build.pekko.version=${{ matrix.pekko-version }} "++${{ matrix.scala-version }} test" ${{ matrix.sbt-opts }}
```
This should be made it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org