You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/10 23:04:08 UTC
[GitHub] [hudi] yihua commented on a diff in pull request #5279: [HUDI-3843] Make flink profiles build with scala-2.11
yihua commented on code in PR #5279:
URL: https://github.com/apache/hudi/pull/5279#discussion_r846860962
##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -38,6 +38,7 @@ fi
declare -a ALL_VERSION_OPTS=(
"-Dscala-2.11 -Dspark2.4 -Dflink1.13"
+"-Dscala-2.11 -Dspark2.4 -Dflink1.14"
Review Comment:
Do we need to add `-Dspark3` related entry as well?
##########
.github/workflows/bot.yml:
##########
@@ -14,51 +14,26 @@ jobs:
build:
runs-on: ubuntu-latest
strategy:
- max-parallel: 8
matrix:
include:
- # Spark 2.4.4, scala 2.11
- scalaProfile: "scala-2.11"
sparkProfile: "spark2.4"
- sparkVersion: "2.4.4"
flinkProfile: "flink1.13"
- # Spark 2.4.4, scala 2.12
- - scalaProfile: "scala-2.12"
+ - scalaProfile: "scala-2.11"
sparkProfile: "spark2.4"
- sparkVersion: "2.4.4"
flinkProfile: "flink1.14"
- # Spark 3.1.x
- - scalaProfile: "scala-2.12"
- sparkProfile: "spark3.1"
- sparkVersion: "3.1.0"
- flinkProfile: "flink1.13"
-
- scalaProfile: "scala-2.12"
- sparkProfile: "spark3.1"
- sparkVersion: "3.1.1"
+ sparkProfile: "spark2.4"
flinkProfile: "flink1.13"
- scalaProfile: "scala-2.12"
sparkProfile: "spark3.1"
- sparkVersion: "3.1.2"
flinkProfile: "flink1.14"
- - scalaProfile: "scala-2.12"
- sparkProfile: "spark3.1"
- sparkVersion: "3.1.3"
Review Comment:
We still need to keep `sparkVersion` to test the spark bundle against patch versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org