[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2677: ARTEMIS-2350 Fix ClassNotFoundException while invoking listConsumers

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2677: ARTEMIS-2350 Fix ClassNotFoundException while invoking listConsumers
URL: https://github.com/apache/activemq-artemis/pull/2677#discussion_r287515899
 
 

 ##########
 File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java
 ##########
 @@ -275,11 +274,11 @@ public static JsonArrayBuilder toJsonArrayBuilder(byte[] byteArray) {
    }
 
    public static JsonArray readJsonArray(String jsonString) {
-      return Json.createReader(new StringReader(jsonString)).readArray();
 
 Review comment:
   I tried calling listConsumers on tests and I couldn't reproduce it.
   
   I'm not saying I don't believe you.. I just don't know what's being fixed without a test beyond the documentaiton you described on the PR comment.
   
   Can you provide a test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services